Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tibber Pulse for homes without active subscriptions #20246

Merged
merged 1 commit into from
Jan 19, 2019
Merged

Tibber Pulse for homes without active subscriptions #20246

merged 1 commit into from
Jan 19, 2019

Conversation

Danielhiversen
Copy link
Member

@Danielhiversen Danielhiversen commented Jan 19, 2019 •
edited
Loading

Description:

Tibber Pulse for homes without active subscriptions

https://github.com/Danielhiversen/pyTibber/commits/master

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

@ghost ghost assigned Danielhiversen Jan 19, 2019
@ghost ghost added the in progress label Jan 19, 2019
@Danielhiversen Danielhiversen changed the title Tibber Pulse for homes without subscriptions Tibber Pulse for homes without active subscriptions Jan 19, 2019
@rohankapoorcom
Copy link
Member

Does this need a docs change?

@Danielhiversen
Copy link
Member Author

No, it should have worked for everyone from the start

@rohankapoorcom rohankapoorcom merged commit 0987219 into dev Jan 19, 2019
@ghost ghost removed the in progress label Jan 19, 2019
@delete-merged-branch delete-merged-branch bot deleted the tibber_pulse_no_subscription branch January 19, 2019 18:23
@balloob balloob mentioned this pull request Feb 6, 2019
Merged
@ghost ghost removed the platform: sensor.tibber label Mar 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rohankapoorcom rohankapoorcom rohankapoorcom approved these changes

Assignees

@Danielhiversen Danielhiversen

Labels
cla-signed integration: tibber small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Danielhiversen @rohankapoorcom @homeassistant