Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add socat dep #24531

Merged
merged 1 commit into from
Jun 19, 2019
Merged

Add socat dep #24531

merged 1 commit into from
Jun 19, 2019

Conversation

torarnv
Copy link
Contributor

@torarnv torarnv commented Jun 14, 2019

Description:

Related issue: fixes #24113

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

@homeassistant homeassistant added small-pr PRs with less than 30 lines. cla-signed labels Jun 14, 2019
Otherwise the tellstick component will fail when used with a
remote host running tellcore-net.

Fixes home-assistant#24113
@balloob
Copy link
Member

balloob commented Jun 14, 2019

How was this not a bug before?

@torarnv
Copy link
Contributor Author

torarnv commented Jun 14, 2019

Not sure, perhaps it's a regression? Or perhaps most people use a locally connected tellstick and don't need the tellcore-net part which needs socat on the HA side. Or perhaps the people who use tellcore-net do it via hass.io where the images are perhaps slightly different, including socat through some other way?

@pvizeli
Copy link
Member

pvizeli commented Jun 19, 2019

That is what Hass.io does and never addded to official Dockerfiles because they run the daemon inside container of every installation.

@torarnv
Copy link
Contributor Author

torarnv commented Jun 19, 2019

Right, I suspected something like that.

Since the tellcore-net feature (specifying a host) is part of the tellstick component socat should be installed so that everything works out of the box with the official HA docker images.

@pvizeli
Copy link
Member

pvizeli commented Jun 19, 2019

One more reason for home-assistant/architecture#243

@balloob balloob merged commit f5da0e3 into home-assistant:dev Jun 19, 2019
@torarnv torarnv deleted the add-socat-dep branch June 19, 2019 19:06
@balloob balloob mentioned this pull request Jun 26, 2019
alandtse pushed a commit to alandtse/home-assistant that referenced this pull request Oct 12, 2019
Otherwise the tellstick component will fail when used with a
remote host running tellcore-net.

Fixes home-assistant#24113
paulsteele referenced this pull request in paulsteele/home-lab Apr 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla-signed small-pr PRs with less than 30 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tellstick: No such file or directory: 'socat': 'socat'
4 participants