Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use signal dispatcher to invoke plaato state update #24627

Merged
merged 1 commit into from
Jun 19, 2019
Merged

Use signal dispatcher to invoke plaato state update #24627

merged 1 commit into from
Jun 19, 2019

Conversation

JohNan
Copy link
Contributor

@JohNan JohNan commented Jun 19, 2019 •
edited
Loading

Description:

Uses signal dispatcher to invoke entity update since calling entity.async_schedule_update_ha_state directly on a non pulling entity is unsafe

Related comment: #23727 (comment)

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist

@ghost ghost assigned JohNan Jun 19, 2019
@JohNan JohNan mentioned this pull request Jun 19, 2019
Merged
8 tasks
MartinHjelmare
MartinHjelmare approved these changes Jun 19, 2019
View reviewed changes
Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@MartinHjelmare MartinHjelmare changed the title Uses signal dispatcher to invoke state update Use signal dispatcher to invoke plaato state update Jun 19, 2019
@MartinHjelmare
Copy link
Member

Can be merged when build passes.

@cgarwood cgarwood merged commit 55997c7 into home-assistant:dev Jun 19, 2019
@balloob balloob mentioned this pull request Jun 26, 2019
Merged
alandtse pushed a commit to alandtse/home-assistant that referenced this pull request Oct 12, 2019
@JohNan @alandtse
Uses signal dispatcher to invoke state update (home-assistant#24627)
4c19a0f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MartinHjelmare MartinHjelmare MartinHjelmare approved these changes

Assignees

@JohNan JohNan

Labels
cla-signed integration: plaato small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@JohNan @MartinHjelmare @cgarwood @homeassistant