Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix/swapped default values in modbus climate #31801

Merged
merged 1 commit into from
Feb 14, 2020
Merged

Bugfix/swapped default values in modbus climate #31801

merged 1 commit into from
Feb 14, 2020

Conversation

vzahradnik
Copy link
Contributor

Proposed change

Modbus climate default values for min and max temperatures are swapped. In documentation: min=5C, max=35C; in code min=35C, max=5. This PR fixes that inconsistency.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

@probot-home-assistant
Copy link

Hey there @adamchengtkc, mind taking a look at this pull request as its been labeled with a integration (modbus) you are listed as a codeowner for? Thanks!

@codecov
Copy link

codecov bot commented Feb 13, 2020

Codecov Report

Merging #31801 into dev will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev   #31801      +/-   ##
==========================================
- Coverage   94.68%   94.67%   -0.01%     
==========================================
  Files         763      763              
  Lines       55137    55148      +11     
==========================================
+ Hits        52206    52212       +6     
- Misses       2931     2936       +5
Impacted Files Coverage Δ
homeassistant/components/template/cover.py 96.34% <0%> (-1.37%) ⬇️
homeassistant/helpers/config_validation.py 95.66% <0%> (-0.4%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f091e04...96edd4e. Read the comment docs.

Copy link
Member

@balloob balloob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@balloob balloob merged commit f0b2d50 into home-assistant:dev Feb 14, 2020
@vzahradnik vzahradnik deleted the bugfix/swapped-default-values-in-modbus-climate branch February 14, 2020 14:23
@lock lock bot locked and limited conversation to collaborators Feb 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants