Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove energy sensor from incompatible Ata devices #31831

Conversation

@vilppuvuorinen
Copy link
Contributor

vilppuvuorinen commented Feb 14, 2020

Proposed change

An AtaDevice has a boolean flag describing whether it supports energy
consumption metering. The flag was ignored resulting in sensor entities
reporting constant 0 kWh consumption. Not critical, but confusing for the user.

  • Update pymelcloud dependency to support the has_energy_consumed_meter
    flag.
  • Add ATTR_ENABLED_FN to sensor definitions for filtering out
    unsupported sensors.
  • Fix typing issue in sensor constructor.
  • Remove unused UnitSystem constructor parameter.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 馃 Silver
  • 馃 Gold
  • 馃弳 Platinum
An AtaDevice has a boolean flag describing whether it supports energy
consumption metering. The flag was ignored resulting in sensor entities
reporting constant 0 kWh consumption.

* Update pymelcloud dependency to support the has_energy_consumed_meter
flag.

* Add ATTR_ENABLED_FN to sensor definitions for filtering out
unsupported sensors.

* Fix typing issue in sensor constructor.

* Remove unused UnitSystem constructor parameter.
@project-bot project-bot bot added this to Needs review in Dev Feb 14, 2020
@project-bot project-bot bot moved this from Needs review to By Code Owner in Dev Feb 14, 2020
@vilppuvuorinen vilppuvuorinen mentioned this pull request Feb 14, 2020
3 of 7 tasks complete
@codecov

This comment was marked as off-topic.

Copy link

codecov bot commented Feb 14, 2020

Codecov Report

Merging #31831 into dev will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev   #31831      +/-   ##
==========================================
+ Coverage   94.65%   94.65%   +<.01%     
==========================================
  Files         763      763              
  Lines       55163    55163              
==========================================
+ Hits        52215    52216       +1     
+ Misses       2948     2947       -1
Impacted Files Coverage 螖
homeassistant/helpers/entity.py 97.61% <0%> (+0.34%) 猬嗭笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update e019280...dc945e8. Read the comment docs.

@vilppuvuorinen vilppuvuorinen requested a review from MartinHjelmare Feb 14, 2020
Copy link
Member

MartinHjelmare left a comment

Looks good!

Dev automation moved this from By Code Owner to Reviewer approved Feb 14, 2020
@MartinHjelmare MartinHjelmare merged commit 614be5c into home-assistant:dev Feb 14, 2020
11 checks passed
11 checks passed
CI Build #20200214.57 succeeded
Details
CI (FullCheck Mypy) FullCheck Mypy succeeded
Details
CI (FullCheck Pylint) FullCheck Pylint succeeded
Details
CI (Overview CheckFormat) Overview CheckFormat succeeded
Details
CI (Overview Lint) Overview Lint succeeded
Details
CI (Overview Validate) Overview Validate succeeded
Details
CI (Tests PyTest Python37) Tests PyTest Python37 succeeded
Details
cla-bot Everyone involved has signed the CLA
codecov/patch Coverage not affected when comparing e019280...dc945e8
Details
codecov/project 94.65% (+<.01%) compared to e019280
Details
docs-missing Documentation ok.
Dev automation moved this from Reviewer approved to Done Feb 14, 2020
@lock lock bot locked and limited conversation to collaborators Feb 15, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants
You can鈥檛 perform that action at this time.