-
-
Notifications
You must be signed in to change notification settings - Fork 30.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support multiple Lovelace dashboards #32134
Conversation
Hey there @home-assistant/frontend, mind taking a look at this pull request as its been labeled with a integration ( |
Hey there @home-assistant/frontend, mind taking a look at this pull request as its been labeled with a integration ( |
Codecov Report
@@ Coverage Diff @@
## dev #32134 +/- ##
==========================================
+ Coverage 94.73% 94.75% +0.02%
==========================================
Files 767 772 +5
Lines 55505 55857 +352
==========================================
+ Hits 52580 52928 +348
- Misses 2925 2929 +4
Continue to review full report at Codecov.
|
9f8ce2a
to
87f2584
Compare
@@ -84,13 +94,23 @@ def __init__(self, hass: HomeAssistant, ll_config: LovelaceConfig): | |||
|
|||
async def _process_create_data(self, data: dict) -> dict: | |||
"""Validate the config is valid.""" | |||
raise NotImplementedError | |||
data = self.CREATE_SCHEMA(data) | |||
data[CONF_TYPE] = data.pop(CONF_TYPE_WS) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not something that the collection should be aware off. We should pop this out before it gets here.
@@ -84,13 +94,23 @@ def __init__(self, hass: HomeAssistant, ll_config: LovelaceConfig): | |||
|
|||
async def _process_create_data(self, data: dict) -> dict: | |||
"""Validate the config is valid.""" | |||
raise NotImplementedError | |||
data = self.CREATE_SCHEMA(data) | |||
data[CONF_TYPE] = data.pop(CONF_TYPE_WS) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not something that the collection should be aware off. We should pop this out before it gets here.
This reverts commit 7d140b2.
Codecov Report
@@ Coverage Diff @@
## dev #32134 +/- ##
==========================================
+ Coverage 94.73% 94.75% +0.02%
==========================================
Files 767 772 +5
Lines 55505 55861 +356
==========================================
+ Hits 52580 52930 +350
- Misses 2925 2931 +6
Continue to review full report at Codecov.
|
Breaking change
Proposed change
Support multiple Lovelace dashboards. YAML only for this PR.
To do:
Type of change
Example entry for
configuration.yaml
:Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.The integration reached or maintains the following Integration Quality Scale: