Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor away deprecated homekit_controller test helpers #32177

Merged

Conversation

Jc2k
Copy link
Member

@Jc2k Jc2k commented Feb 25, 2020

Proposed change

This is a test only change to remove some test helper classes - FakePairing and FakeController. Upstream has better implementations which we are already using in the config flow tests, this just finishes the migration.

This is a precursor to my branch to enable support for HomeKit push events (don't want to re-implement a bunch of test infrastructure downstream).

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

@codecov
Copy link

codecov bot commented Feb 25, 2020

Codecov Report

Merging #32177 into dev will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev   #32177      +/-   ##
==========================================
+ Coverage   94.75%   94.75%   +<.01%     
==========================================
  Files         768      768              
  Lines       55639    55639              
==========================================
+ Hits        52721    52722       +1     
+ Misses       2918     2917       -1
Impacted Files Coverage Δ
homeassistant/helpers/entity.py 97.64% <0%> (+0.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 438c4ac...544cdfb. Read the comment docs.

@MartinHjelmare MartinHjelmare merged commit 1ddc1eb into home-assistant:dev Feb 25, 2020
@Jc2k Jc2k deleted the homekit_controller_test_refactor branch February 25, 2020 20:36
@lock lock bot locked and limited conversation to collaborators Feb 28, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants