Implement ezviz PTZ & switches

[BaQs]

Breaking change

Proposed change

Implemented PTZ, and different switchez to the Ezviz camera component.
Like the ability to switch on/off the Infra Red, the Led, the movement detection.

Type of change

• Dependency upgrade
• Bugfix (non-breaking change which fixes an issue)
• New integration (thank you!)
• New feature (which adds functionality to an existing integration)
• Breaking change (fix/feature causing existing functionality to break)
• Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

• This PR fixes or closes issue: fixes #
• This PR is related to issue:
• Link to documentation pull request:

Checklist

• The code change is tested and works locally.
• Local tests pass. Your PR cannot be merged unless tests pass
• There is no commented out code in this PR.
• I have followed the development checklist
• The code has been formatted using Black (black --fast homeassistant tests)
• Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

• Documentation added/updated for www.home-assistant.io
  TBD

If the code communicates with devices, web services, or third-party tools:

• The manifest file has all fields filled out correctly.
  Updated and included derived files by running: python3 -m script.hassfest.
• New or updated dependencies have been added to requirements_all.txt.
  Updated by running python3 -m script.gen_requirements_all.
• Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

• No score or internal
• 🥈 Silver
• 🥇 Gold
• 🏆 Platinum

[probot-home-assistant]

Hey there @BaQs, mind taking a look at this pull request as its been labeled with a integration (ezviz) you are listed as a codeowner for? Thanks!

[BaQs]

Hey there @BaQs, mind taking a look at this pull request as its been labeled with a integration (ezviz) you are listed as a codeowner for? Thanks!

Indeed I am :)
But if somebody with proper HASS/Python skills would review it, should be even better !

[bdraco]

How about adding some tests for these?

[BaQs]

How about adding some tests for these?

I aggree, but I would need some help & some time for this :)

[bdraco]

@BaQs It looks like you are implementing switches as services.

Please use the switch platform

https://developers.home-assistant.io/docs/entity_switch

[BaQs]

@BaQs It looks like you are implementing switches as services.

Please use the switch platform

https://developers.home-assistant.io/docs/entity_switch

I'm trying to implement switches properly.
If I generate the entities from the camera.py, it's considered as a camera...
If I create a new switch.py and properly setup the platform, I have no way to parse the already-existing cameras.
I did not find any code I could read as an example.

What would you suggest ?

[bdraco]

@BaQs It looks like you are implementing switches as services.
Please use the switch platform
https://developers.home-assistant.io/docs/entity_switch

I'm trying to implement switches properly.
If I generate the entities from the camera.py, it's considered as a camera...
If I create a new switch.py and properly setup the platform, I have no way to parse the already-existing cameras.
I did not find any code I could read as an example.

What would you suggest ?

You will need to centralize your configuration logic:

Checkout https://developers.home-assistant.io/docs/creating_component_generic_discovery

The wled integration is a good example.

[stale]

There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days.
Thank you for your contributions.