-
-
Notifications
You must be signed in to change notification settings - Fork 30.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Xiaomi Aqara Config Flow #35595
Add Xiaomi Aqara Config Flow #35595
Conversation
To Do:
|
@Danielhiversen I am not sure if the XiaomiGateway class of the pyxiaomigateway library does I/O? |
gateway_instance = await hass.async_add_executor_job(
gateway_class, param1, param2
) |
@MartinHjelmare this lint test failure is totally unrelated: Could you restart the tests? |
Please rebase on latest dev branch to let the build pass. |
First tested and working version
This is needed to prevent a conflict with the Xiaomi Miio integration that I discovered during testing.
@MartinHjelmare I have fully tested this. |
I think the failed tests are unrelated to this PR, could you confirm @MartinHjelmare |
@MartinHjelmare any more feedback? |
@MartinHjelmare can you now approve? |
@MartinHjelmare tested the code again, and everything seems to work. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good!
Please update the breaking change paragraph and mention that if no key is set only the binary_sensor and sensor platforms will be loaded. A key is required to activate the other platforms. |
@MartinHjelmare I added it to the breaking change |
Breaking change
YAML configuration of the xiaomi_aqara component has been deprecated, please remove the xiaomi_aqara platform from your configuration.yaml file.
The xiaomi_aqara component now uses the new Config Flow.
Xiaomi Aqara Gateways schould be discovered automatically and show up under "Configuration"-> "Integrations", from there hit configure and go through the steps.
If your Xiaomi Aqara Gateway does not show up automatically, go to "Configuration"-> "Integrations"-> press the "+" icon -> search for "xiaomi_aqara" and enter the setup.
If no key is provided during setup, only the binary_sensor and sensor platforms will be available. A key is required to activate the other platforms.
Proposed change
Type of change
Example entry for
configuration.yaml
:Config Flow :)
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.The integration reached or maintains the following Integration Quality Scale: