Add samsungtv zeroconf discovery #35773

escoand · 2020-05-18T10:26:54Z

Breaking change

Proposed change

Add samsungtv zeroconf discovery

Type of change

Dependency upgrade
Bugfix (non-breaking change which fixes an issue)
New integration (thank you!)
New feature (which adds functionality to an existing integration)
Breaking change (fix/feature causing existing functionality to break)
Code quality improvements to existing code or addition of tests

Example entry for `configuration.yaml`:

# Example configuration.yaml

Additional information

This PR fixes or closes issue: fixes 0.109.b4: Samsung sound bar detected as TV #34810, fixes Samsung TV integration detected multiple times (every time TV powers on). #35600, fixes Samsung TV keeps being rediscoved, even if ignored #35790, fixes SamsungTV doesn't add an entity #36901
This PR is related to issue:
Link to documentation pull request:

Checklist

The code change is tested and works locally.
Local tests pass. Your PR cannot be merged unless tests pass
There is no commented out code in this PR.
I have followed the development checklist
The code has been formatted using Black (black --fast homeassistant tests)
Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

Documentation added/updated for www.home-assistant.io

If the code communicates with devices, web services, or third-party tools:

The manifest file has all fields filled out correctly.
Updated and included derived files by running: python3 -m script.hassfest.
New or updated dependencies have been added to requirements_all.txt.
Updated by running python3 -m script.gen_requirements_all.
Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

No score or internal
🥈 Silver
🥇 Gold
🏆 Platinum

…nto samsungtv_zeroconf

escoand · 2020-05-20T05:54:01Z

@chemelli74 Are you brave enough to do a first test? I would expect that it's not working as custom_component, you need to checkout the complete HA code and run from there.

chemelli74 · 2020-05-20T09:13:18Z

@chemelli74 Are you brave enough to do a first test? I would expect that it's not working as custom_component, you need to checkout the complete HA code and run from there.

Why not, I have a docker test environment that is there exactly for those situations ;-)
Would be enough to git checkout overwriting current files ? or what ?

Simone

escoand · 2020-05-20T10:52:08Z

Not sure. Run it directly. But a docker build --tag HAtest . && docker run --rm HAtest should do it.

escoand · 2020-05-20T18:27:46Z

@chemelli74 I hope you had not too much work until now. There are many outstanding point. Please wait for my next message...

escoand · 2020-05-20T19:38:18Z

@chemelli74 as you can see there are some questions unclear, but now you could test it.

chemelli74 · 2020-05-20T19:39:38Z

@chemelli74 as you can see there are some questions unclear, but now you could test it.

I used files from previous commit:

2020-05-20 20:59:29 ERROR (MainThread) [homeassistant.core] Error doing job: Task exception was never retrieved
Traceback (most recent call last):
  File "/usr/src/homeassistant/homeassistant/data_entry_flow.py", line 129, in async_init
    flow, flow.init_step, data, init_done
  File "/usr/src/homeassistant/homeassistant/data_entry_flow.py", line 201, in _async_handle_step
    result: Dict = await getattr(flow, method)(user_input)
  File "/usr/src/homeassistant/homeassistant/components/samsungtv/config_flow.py", line 161, in async_step_zeroconf
    self._model = device_info.get("device", {}).get("modelName")
AttributeError: 'SamsungTVWSBridge' object has no attribute 'get'

Simone

escoand · 2020-05-20T19:49:16Z

Please use the most recently pushed code.

chemelli74 · 2020-05-20T22:14:09Z

Please use the most recently pushed code.

Updated, same result:

2020-05-21 00:10:29 ERROR (MainThread) [homeassistant.core] Error doing job: Task exception was never retrieved
Traceback (most recent call last):
  File "/usr/src/homeassistant/homeassistant/data_entry_flow.py", line 129, in async_init
    flow, flow.init_step, data, init_done
  File "/usr/src/homeassistant/homeassistant/data_entry_flow.py", line 201, in _async_handle_step
    result: Dict = await getattr(flow, method)(user_input)
  File "/usr/src/homeassistant/homeassistant/components/samsungtv/config_flow.py", line 161, in async_step_zeroconf
    self._model = device_info.get("device", {}).get("modelName")
AttributeError: 'SamsungTVWSBridge' object has no attribute 'get'

Simone

pergolafabio · 2020-08-31T18:50:53Z

Do you have an update for me ? @escoand ?

chemelli74 · 2020-09-03T15:20:30Z

Any chance to see this PR merged ?

Simone

escoand · 2020-09-03T16:12:48Z

It's still on my agenda, but with 3 kids and other things is also quiet busy. Family is definitely priority 1. Will work on it again when I have some minutes...

pergolafabio · 2020-09-03T16:20:26Z

But it's not finished yet to be merged since I have that "str" issue I posted earlier?

Take your time, I have 2 kids, couldn't imagine to have 3 ;)

escoand · 2020-09-03T17:30:36Z

@pergolafabio The difference from 0 to 1 is like a complete new life, but it's getting less and less diff with every new. In the hospital they said to us "3 is the new 2". ;-D

chemelli74 · 2020-09-04T18:20:48Z

But it's not finished yet to be merged since I have that "str" issue I posted earlier?

Take your time, I have 2 kids, couldn't imagine to have 3 ;)

Sorry, missed your comment.

Simone

escoand · 2020-09-08T13:37:14Z

@pergolafabio @chemelli74 Could you please retry with the last commit?

pergolafabio · 2020-09-08T17:03:59Z

ok, loaded patch 1
i had no samsung devices in HA
after restart, i also powered on my old non-tizen tv :

receive this error

2020-09-08 18:58:15 ERROR (MainThread) [homeassistant] Error doing job: Task exception was never retrieved
Traceback (most recent call last):
  File "/usr/src/homeassistant/homeassistant/data_entry_flow.py", line 128, in async_init
    result = await self._async_handle_step(
  File "/usr/src/homeassistant/homeassistant/data_entry_flow.py", line 201, in _async_handle_step
    result: Dict = await getattr(flow, method)(user_input)
  File "/config/custom_components/samsungtv/config_flow.py", line 189, in async_step_ssdp
    await self._abort_if_already_configured()
  File "/config/custom_components/samsungtv/config_flow.py", line 105, in _abort_if_already_configured
    self._host == entry.data[CONF_HOST]
KeyError: 'host'

also added my tizen TV, i got a popup on tv ... HA wants to access ... pressed allow ...
but again same error as above

MartinHjelmare · 2020-09-09T06:51:11Z

tests/components/samsungtv/test_config_flow.py

@@ -612,6 +624,7 @@ async def test_autodetect_legacy(hass: HomeAssistantType, remote: Mock):
        result = await hass.config_entries.flow.async_init(
            DOMAIN, context={"source": "user"}, data=MOCK_USER_DATA
        )
+        print(result)


Please remove debug print.

MartinHjelmare · 2020-09-09T06:54:37Z

homeassistant/components/samsungtv/config_flow.py

+
+        await self._abort_if_already_configured()
+
+        self.context["title_placeholders"] = {"model": self._model}


Is it ok to have model be None here?

MartinHjelmare · 2020-09-09T06:55:10Z

homeassistant/components/samsungtv/config_flow.py

-        self._name = f"Samsung {self._model}"
-        self._id = discovery_info.get(ATTR_UPNP_UDN)
-        self._title = self._model
+    async def async_step_ssdp(self, user_input=None):


Suggested change

async def async_step_ssdp(self, user_input=None):

async def async_step_ssdp(self, discovery_info):

MartinHjelmare · 2020-09-09T06:56:03Z

homeassistant/components/samsungtv/config_flow.py

+        self.context["title_placeholders"] = {"model": self._model}
+        return await self.async_step_confirm()
+
+    async def async_step_zeroconf(self, user_input=None):


Suggested change

async def async_step_zeroconf(self, user_input=None):

async def async_step_zeroconf(self, discovery_info):

MartinHjelmare · 2020-09-09T06:56:52Z

homeassistant/components/samsungtv/config_flow.py

+        self._mac = user_input[ATTR_PROPERTIES].get("deviceid")
+        self._manufacturer = user_input[ATTR_PROPERTIES].get("manufacturer")
+        if not self._model:
+            self._model = user_input[ATTR_PROPERTIES].get("model")


Don't use dict.get if we don't handle a None value returned.

stale · 2020-10-12T00:07:58Z

There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days.
Thank you for your contributions.

chemelli74 · 2020-10-12T06:17:30Z

Prevent closing; will be a real pity with all the work done.

Simone

chemelli74 · 2020-11-01T10:01:41Z

HI @escoand, I know your are very busy with real life and I don't want to sound rude.
I would just like to know if there is something I can do you help you getting this PR ready to merge.

Thank you again for your great work,

Simone

escoand · 2020-11-17T19:34:01Z

I'm also annoyed by the current situation. The code is quite matured but still not ready. The PR is still present in my head but I couldn't find the time and motivation to finalize it. When I have the time I will first work on this.

balloob · 2021-01-14T09:06:34Z

This PR seems to have gone stale. Closing it.

chemelli74 · 2021-02-18T23:46:00Z

@escoand, do you mind if I take over and try to finalize your work ? You did 99% is a pity to lost it.

Simone

escoand · 2021-02-22T13:26:14Z

@chemelli74 Yes sure, feel free to finalize it, thanks. For me it's currently really not possible specifically because I don't have a websocket device.

chemelli74 · 2021-03-09T23:13:13Z

@pergolafabio I would like to get in touch with you and complete the great work from @escoand.
Please look around for me on Discord

Simone

pergolafabio · 2021-03-10T09:30:14Z

ok, whats your ID?
i must say, i dont use the samsung integration, they are just added to HA as idle devices :-)
for now, i have put them to static IP with dhcp reservation, so i dont see the error at this moment

chemelli74 · 2021-03-10T09:33:07Z

ok, whats your ID?

chemelli74#2180

escoand added 5 commits May 16, 2020 08:05

Add samsungtv zeroconf

42b1745

update unique id

965becd

Update config_flow.py

53454a3

Update config_flow.py

a8c6a6f

.

d115cba

homeassistant added the cla-signed label May 18, 2020

probot-home-assistant bot added code-quality integration: samsungtv new-feature by-code-owner labels May 18, 2020

escoand added 6 commits May 18, 2020 12:56

flake

4deffb2

hassfest

9ee5b11

Update __init__.py

6b1b832

Update const.py

78fdb62

add device info

3958f39

Merge branch 'patch-1' of https://github.com/escoand/home-assistant i…

a87d6e2

…nto samsungtv_zeroconf

Merge remote-tracking branch 'upstream/dev' into samsungtv_zeroconf

70f6b81

escoand added 2 commits May 20, 2020 21:09

fix tests

62f21fd

minor

f5877ab

escoand added 2 commits September 8, 2020 15:32

fix device info

7b4d75f

Merge branch 'dev' into patch-1

295558b

MartinHjelmare reviewed Sep 9, 2020

View reviewed changes

stale bot added the stale label Oct 12, 2020

stale bot removed the stale label Oct 12, 2020

balloob closed this Jan 14, 2021

This was referenced Jan 20, 2021

Samsung tv gets discoverd every time it's switched on #44493

Closed

Samsung TV integration disconnects and repeat reauth on TV. Since 0.114 #41305

Closed

This was referenced Mar 10, 2021

Add samsungtv zeroconf discovery #47715

Closed

Add samsungtv dhcp and zeroconf discovery #48022

Merged

escoand deleted the patch-1 branch December 29, 2023 21:16

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add samsungtv zeroconf discovery #35773

Add samsungtv zeroconf discovery #35773

escoand commented May 18, 2020 •

edited

Loading

escoand commented May 20, 2020

chemelli74 commented May 20, 2020

escoand commented May 20, 2020 •

edited

Loading

escoand commented May 20, 2020

escoand commented May 20, 2020

chemelli74 commented May 20, 2020

escoand commented May 20, 2020

chemelli74 commented May 20, 2020

pergolafabio commented Aug 31, 2020

chemelli74 commented Sep 3, 2020

escoand commented Sep 3, 2020

pergolafabio commented Sep 3, 2020

escoand commented Sep 3, 2020

chemelli74 commented Sep 4, 2020

escoand commented Sep 8, 2020

pergolafabio commented Sep 8, 2020

MartinHjelmare Sep 9, 2020

MartinHjelmare Sep 9, 2020

MartinHjelmare Sep 9, 2020

MartinHjelmare Sep 9, 2020

MartinHjelmare Sep 9, 2020

stale bot commented Oct 12, 2020

chemelli74 commented Oct 12, 2020

chemelli74 commented Nov 1, 2020

escoand commented Nov 17, 2020

balloob commented Jan 14, 2021

chemelli74 commented Feb 18, 2021

escoand commented Feb 22, 2021

chemelli74 commented Mar 9, 2021

pergolafabio commented Mar 10, 2021

chemelli74 commented Mar 10, 2021


		await self._abort_if_already_configured()

		self.context["title_placeholders"] = {"model": self._model}

	async def async_step_ssdp(self, user_input=None):
	async def async_step_ssdp(self, discovery_info):

	async def async_step_zeroconf(self, user_input=None):
	async def async_step_zeroconf(self, discovery_info):

Add samsungtv zeroconf discovery #35773

Add samsungtv zeroconf discovery #35773

Conversation

escoand commented May 18, 2020 • edited Loading

Breaking change

Proposed change

Type of change

Example entry for configuration.yaml:

Additional information

Checklist

escoand commented May 20, 2020

chemelli74 commented May 20, 2020

escoand commented May 20, 2020 • edited Loading

escoand commented May 20, 2020

escoand commented May 20, 2020

chemelli74 commented May 20, 2020

escoand commented May 20, 2020

chemelli74 commented May 20, 2020

pergolafabio commented Aug 31, 2020

chemelli74 commented Sep 3, 2020

escoand commented Sep 3, 2020

pergolafabio commented Sep 3, 2020

escoand commented Sep 3, 2020

chemelli74 commented Sep 4, 2020

escoand commented Sep 8, 2020

pergolafabio commented Sep 8, 2020

MartinHjelmare Sep 9, 2020

Choose a reason for hiding this comment

MartinHjelmare Sep 9, 2020

Choose a reason for hiding this comment

MartinHjelmare Sep 9, 2020

Choose a reason for hiding this comment

MartinHjelmare Sep 9, 2020

Choose a reason for hiding this comment

MartinHjelmare Sep 9, 2020

Choose a reason for hiding this comment

stale bot commented Oct 12, 2020

chemelli74 commented Oct 12, 2020

chemelli74 commented Nov 1, 2020

escoand commented Nov 17, 2020

balloob commented Jan 14, 2021

chemelli74 commented Feb 18, 2021

escoand commented Feb 22, 2021

chemelli74 commented Mar 9, 2021

pergolafabio commented Mar 10, 2021

chemelli74 commented Mar 10, 2021

escoand commented May 18, 2020 •

edited

Loading

Example entry for `configuration.yaml`:

escoand commented May 20, 2020 •

edited

Loading