Improve Xioami Aqara zeroconf discovery handling

[starkillerOG]

Breaking change

Proposed change

Improve the handeling of a zeroconf discovered xiaomi aqara gateway.
This illiminates the need for a network search of the gateway, because the required information is already known.

fix issue with not beeing able to bind to interface if using some operating systems.

ensure listener loop can exit succesfully by setting a timeout and catching that timeout. (I experianced issues with homeassistant not beeing able to close or remove the xiaomi_aqara integration because it hangs forever on data, (ip_add, _) = self._mcastsocket.recvfrom(self.SOCKET_BUFSIZE) (there was no timeout) which prevented the listener loop to exit.

Allow users to mannualy specify an IP an Mac address if both the SSDP and auto-discovery fail.

Type of change

• Dependency upgrade
• Bugfix (non-breaking change which fixes an issue)
• New integration (thank you!)
• New feature (which adds functionality to an existing integration)
• Breaking change (fix/feature causing existing functionality to break)
• Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

Config flow

Additional information

• This PR fixes or closes issue: fixes Multiple Xiaomi Gateways via Integration page not working #37306 and Xiaomi-Aqara Gateway via Integration page can't be found because of lack of option "host" in new integration GUI #37661
• This PR is related to issue:
• Link to documentation pull request:

Checklist

• The code change is tested and works locally.
• Local tests pass. Your PR cannot be merged unless tests pass
• There is no commented out code in this PR.
• I have followed the development checklist
• The code has been formatted using Black (black --fast homeassistant tests)
• Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

• Documentation added/updated for www.home-assistant.io

If the code communicates with devices, web services, or third-party tools:

• The manifest file has all fields filled out correctly.
  Updated and included derived files by running: python3 -m script.hassfest.
• New or updated dependencies have been added to requirements_all.txt.
  Updated by running python3 -m script.gen_requirements_all.
• Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

• No score or internal
• 🥈 Silver
• 🥇 Gold
• 🏆 Platinum

[probot-home-assistant]

Hey there @Danielhiversen, @syssi, mind taking a look at this pull request as its been labeled with an integration (xiaomi_aqara) you are listed as a codeowner for? Thanks!
_{^{(message by CodeOwnersMention)}}

[starkillerOG]

@Danielhiversen You just released PyXiaomiGateway on github and can see it under github releases.
However PyPi still shows 0.12.4 as the latest release and does not show 0.13.0....
Can you fix that?

[Danielhiversen]

The travis tests failed, so it was not pushed to pypi https://travis-ci.org/github/Danielhiversen/PyXiaomiGateway

[meichthys]

FYI - the build is now passing and pypi is up to date with PyXiaomiGateway v0.13.2

[starkillerOG]

@frenck could you add this to the 0.113.3 milestone?
A lot of people are waiting for this fix to be able to use the xiaomi_aqara integration again.

[starkillerOG]

Could someone merge this?

[starkillerOG]

@MartinHjelmare thanks for the revieuw!
I proccesed all feedback, only the translations I am not sure about.

[starkillerOG]

@MartinHjelmare the script.translations develop has been run, can you now approve?

[starkillerOG]

@MartinHjelmare Looks like the test failure is unrelated to this PR.
Something with the template binary sensor in this file: tests/components/template/test_binary_sensor.py

[MartinHjelmare]

Good!

[frenck]

@syssi, you've tagged it for 0.114.0, but this is an improvement, not a fix, right?

[starkillerOG]

@frenck it is both, it makes some improvements but mainly it fixes an issue that prevents lots of users to setup the integration.
See issues #37306 and #37661 and Danielhiversen/PyXiaomiGateway#179

[frenck]

Ok, in that case, I'm a bit in the middle. The general policy is that we do not allow for new features/improvements after cutting the beta, only fixes.

@MartinHjelmare What do you think?

[balloob]

Instead of having this step, we should do discovery first, and then show a drop down of found entries with "Manual" being one of the options.

[balloob]

We can do this in a future PR.

[starkillerOG]

Thanks for the hint, that indeed sounds like a nice improvement.
There already is a drop down list in case multiple gateways are discovered using discovery so schould not be to hard to implement this.

I will not have time in the near future to do this, but I will keep it in mind to do it sometime in the future.

[balloob]

It's fine to put this in the beta as we're 1 day in. Should be enough time to get things fixed.