Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC] Add Tag integration #38727

Merged
merged 15 commits into from
Aug 11, 2020
Merged

[RFC] Add Tag integration #38727

merged 15 commits into from
Aug 11, 2020

Conversation

dmulcahey
Copy link
Contributor

@dmulcahey dmulcahey commented Aug 10, 2020

Proposed change

This PR adds initial support for creating and scanning tags.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

@dmulcahey
Copy link
Contributor Author

ready for 👀 again

vol.Required(CONF_ID): cv.string,
vol.Optional(CONF_NAME): vol.All(str, vol.Length(min=1)),
vol.Optional("description"): cv.string,
vol.Optional(LAST_SCANNED): cv.datetime,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's make this required.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed, if we let folks manually register these in a helper UI this may not be present for a create.

dmulcahey and others added 2 commits August 10, 2020 17:37
Co-authored-by: Paulus Schoutsen <paulus@home-assistant.io>
@dmulcahey dmulcahey marked this pull request as ready for review August 10, 2020 21:39
@balloob balloob merged commit 227d7c0 into home-assistant:dev Aug 11, 2020
@frenck
Copy link
Member

frenck commented Aug 11, 2020

This PR is missing documentation upstream. @dmulcahey Could you open a PR to add this?

@Hedda
Copy link
Contributor

Hedda commented Aug 11, 2020

@dmulcahey Noticed that this component was renamed from "NFC Tags" to "Tag" which is much more generic. Just wondering now if this is still meant specific for NFC (Near-Field Communication) tags standard only or is this also meant to cover tags using other Radio-Frequency Identification (RFID) protocols and standards as well?

@balloob
Copy link
Member

balloob commented Aug 11, 2020

Any type of tag.

@dmulcahey dmulcahey deleted the dm/nfc-tags branch December 18, 2021 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants