-
-
Notifications
You must be signed in to change notification settings - Fork 30.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure we always fire time pattern changes after microsecond 0 #39302
Merged
balloob
merged 1 commit into
home-assistant:dev
from
bdraco:time_pattern_fire_after_microsecond_zero
Aug 28, 2020
Merged
Ensure we always fire time pattern changes after microsecond 0 #39302
balloob
merged 1 commit into
home-assistant:dev
from
bdraco:time_pattern_fire_after_microsecond_zero
Aug 28, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bdraco
force-pushed
the
time_pattern_fire_after_microsecond_zero
branch
from
August 27, 2020 00:52
3ea835b
to
829f65f
Compare
Testing with this automation
|
bdraco
force-pushed
the
time_pattern_fire_after_microsecond_zero
branch
from
August 27, 2020 00:59
829f65f
to
f288cfc
Compare
bdraco
force-pushed
the
time_pattern_fire_after_microsecond_zero
branch
from
August 27, 2020 13:44
f288cfc
to
b78387f
Compare
balloob
approved these changes
Aug 28, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good. It's wild that it can cost so much.
I've been running it for a day now without any issues. My system is fast at getting time though so I'm not the best test here. |
Let's get it running in dev/beta and see if we break something 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2nd attempt at fixing #39012 (more desirable option)
Proposed change
Ensure we always fire time pattern changes after microsecond 0
Type of change
Example entry for
configuration.yaml
:# Example configuration.yaml
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: