Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove deprecated things #4037

Merged
merged 4 commits into from
Oct 25, 2016
Merged

Remove deprecated things #4037

merged 4 commits into from
Oct 25, 2016

Conversation

robbiet480
Copy link
Member

@robbiet480 robbiet480 commented Oct 25, 2016

garage_door and rollershutter were merged into cover as of 0.27 and marked for deprecation at that time. It's been a few versions, so now it is time to remove them entirely from the source. hvac and thermostat were also merged to form the new climate component.

Removes the following components and all their platforms:

  • garage_door
  • hvac
  • rollershutter
  • thermostat

See also home-assistant/home-assistant.io#1314

@mention-bot
Copy link

@robbiet480, thanks for your PR! By analyzing the history of the files in this pull request, we identified @turbokongen, @kk7ds and @balloob to be potential reviewers.

@balloob
Copy link
Member

balloob commented Oct 25, 2016

🐬 when tests pass.

@robbiet480
Copy link
Member Author

@MartinHjelmare Can you assist us with removing some of the changes you made to helpers/state.py? Specifically, here and everything related. We're not sure what to remove or leave and also if this should be migrated to climate or not.

@MartinHjelmare
Copy link
Member

I'll take a look.

@robbiet480
Copy link
Member Author

@MartinHjelmare I think I figured it out. Waiting for tests to pass.

@robbiet480
Copy link
Member Author

Tests passed. Do you want to check my commit to make sure I did it right? b36e346

@MartinHjelmare
Copy link
Member

Looks good.

@MartinHjelmare
Copy link
Member

All these services can be removed from const.py and helpers/state.py:
SERVICE_MOVE_UP, SERVICE_MOVE_DOWN, SERVICE_OPEN, SERVICE_CLOSE

Sorry I missed that before.

@MartinHjelmare
Copy link
Member

And also from const.py:
SERVICE_MOVE_POSITION, SERVICE_STOP.

@robbiet480
Copy link
Member Author

Once tests pass I will merge this and the related PRs.

@robbiet480 robbiet480 merged commit 79da1ec into dev Oct 25, 2016
@balloob balloob deleted the remove-deprecated-things branch November 6, 2016 00:10
@home-assistant home-assistant locked and limited conversation to collaborators Mar 17, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants