-
-
Notifications
You must be signed in to change notification settings - Fork 30.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add area id to entity registry #42221
Conversation
@balloob @bramkragten should we expose the device area id per entity as well or should that be a frontend thing? |
…nt and add tests to verify
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🎉 Looking good.
@bramkragten do you think that this is good to go? We can always extend APIs later if we need to.
Yes, I think this will work |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should avoid using the word entity for entity entries in the entity registry.
Can be merged once Martin's comments addressed! 🎉 |
Co-authored-by: Martin Hjelmare <marhje52@gmail.com>
Co-authored-by: Martin Hjelmare <marhje52@gmail.com>
Thanks everyone 🎉 |
thanks @MartinHjelmare |
Co-authored-by: Martin Hjelmare <marhje52@gmail.com>
If I request the state of an entity, the API didn't exposed the area id. |
The Entity registry is not part of the state machine. |
Breaking change
Proposed change
Support adding area id to entity entries. Update service helper support and search integration to find entities in area.
Type of change
Example entry for
configuration.yaml
:# Example configuration.yaml
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: