Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix media renderers without volume control #44874

Merged
merged 2 commits into from
Jan 8, 2021
Merged

Conversation

ocampana
Copy link
Contributor

@ocampana ocampana commented Jan 6, 2021

This is the solution proposed by #apfelmaennchen in issue 30395

Breaking change

No breaking change

Proposed change

This is necessary for DLNA renderers that do not export volume control. Without this change, those devices appear as broken in the UI.

Type of change

  • Dependency upgrade
  • [* ] Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml
media_player:
  - platform: dlna_dmr
    name: Sony SA-NS410
    url: http://192.168.30.96:8000/serverxml.xml

Additional information

Checklist

  • [* ] The code change is tested and works locally.
  • [* ] Local tests pass. Your PR cannot be merged unless tests pass
  • [ *] There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

This is the solution proposed by  #apfelmaennchen in issue 30395
@homeassistant
Copy link
Contributor

Hi @ocampana,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

Copy link
Member

@balloob balloob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Have you tested this locally?

@ocampana
Copy link
Contributor Author

ocampana commented Jan 7, 2021

@balloob I have this change running on my installation of home assistant at home and it works.

Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @ocampana 👍

@frenck frenck merged commit 58195c6 into home-assistant:dev Jan 8, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Jan 9, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DLNA_DMR: Error doing job: Task exception was never retrieved (Missing StateVariable RC/Volume)
4 participants