Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix zwave_js sensor device class attribute error #45863

Merged
merged 1 commit into from
Feb 2, 2021

Conversation

MartinHjelmare
Copy link
Member

@MartinHjelmare MartinHjelmare commented Feb 2, 2021

Breaking change

Proposed change

2021-02-02 14:04:10 ERROR (MainThread) [homeassistant.components.sensor] Error adding entities for domain sensor with platform zwave_js
Traceback (most recent call last):
  File "/home/martin/dev/home-assistant/core/homeassistant/helpers/entity_platform.py", line 315, in async_add_entities
    await asyncio.gather(*tasks)
  File "/home/martin/dev/home-assistant/core/homeassistant/helpers/entity_platform.py", line 423, in _async_add_entity
    device_class=entity.device_class,
  File "/home/martin/dev/home-assistant/core/homeassistant/components/zwave_js/sensor.py", line 76, in device_class
    if "temperature" in self.info.primary_value.property_.lower():
AttributeError: 'int' object has no attribute 'lower'

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example entry for configuration.yaml:

# Example configuration.yaml

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant probot-home-assistant bot added integration: zwave_js small-pr PRs with less than 30 lines. labels Feb 2, 2021
@MartinHjelmare MartinHjelmare added this to the 2021.2.0 milestone Feb 2, 2021
Copy link
Contributor

@raman325 raman325 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏾

Copy link
Member

@balloob balloob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good. For another PR, is this something that we can compute when we instantiate the class instead on each time we read this property?

@balloob balloob merged commit c93fec3 into dev Feb 2, 2021
@balloob balloob deleted the fix-zwave_js-sensor-attribute-error branch February 2, 2021 15:25
marengaz pushed a commit to marengaz/core that referenced this pull request Feb 3, 2021
@github-actions github-actions bot locked and limited conversation to collaborators Feb 3, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants