-
-
Notifications
You must be signed in to change notification settings - Fork 30.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Flexpool.io Sensors Integration #47995
Conversation
Checks are done. Thank you for your help with the test, Nathan. :) |
I believe review approval is still missing or do you not have permission to fully review PRs? I don't quite know how things work here. |
If you're asking me, that is correct, I am not a core developer, only a contributor. My review does not give you reviewer approval. One of those devs will be around at some point, they're pretty busy so be patient! |
Okay, I thought so. Thank you so much for taking your time to review it anyway. There were changes needed after all |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi there @DatDraggy 👋
I did an initial review pass, to get some things going and moving.
I think the biggest change you should consider, is implementing the DataUpdateCoordinator
.
Some of the suggestions in this review, might require you to rebase this PR onto the latest dev
branch first.
../Frenck 🚂
Co-authored-by: Nathan Tilley <nathan@tilley.xyz>
Co-authored-by: Franck Nijhof <frenck@frenck.nl>
Co-authored-by: Franck Nijhof <frenck@frenck.nl>
Co-authored-by: Franck Nijhof <frenck@frenck.nl>
Co-authored-by: Franck Nijhof <frenck@frenck.nl>
Co-authored-by: Franck Nijhof <frenck@frenck.nl>
Co-authored-by: Franck Nijhof <frenck@frenck.nl>
Co-authored-by: Franck Nijhof <frenck@frenck.nl>
Co-authored-by: Franck Nijhof <frenck@frenck.nl>
Co-authored-by: Franck Nijhof <frenck@frenck.nl>
3f522c3
to
691207b
Compare
def6d81
to
31c54b2
Compare
Alright, all feedback was implemented as far as possible. The official python package kind of limits the usage of the update coordinator, but it does reduce the amount of api calls. |
There will be a new api wrapper soon so I'm going to put this PR on hold for now until I have implemented the new one. It improve performance drastically. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Look at it again, added a comment (besides the comments that are still open at this point). Could you take a look at those @DatDraggy? 👍
homeassistant/components/flexpool/__init__.py | ||
homeassistant/components/flexpool/const.py | ||
homeassistant/components/flexpool/helper.py | ||
homeassistant/components/flexpool/sensor.py |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please keep this file alphabetically sorted.
There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days. |
Proposed change
I am adding a few sensors for the Ethereum mining pool Flexpool.io to homeassistant as my first integration.
I've been asked by other HA users to try my luck at an integration for this pool.
As mentioned, this is the first time working on HA for me. I've looked at other sensor integrations to get a grasp of how that could look like, but I'm not sure if what I've done makes sense or could be done better.
Type of change
Example Configuration:
Example address for testing 0x5F8A1ae37f7caDA442241BE98b507E2455A3121D
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: