-
-
Notifications
You must be signed in to change notification settings - Fork 30.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Block custom integrations with missing or invalid version #49916
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Shouldn't there be a doc PR to identify the fact it's no longer a future requirement?
The documentation always stated that it's required https://developers.home-assistant.io/docs/creating_integration_manifest#version EDIT: The blog post stated it was a future version home-assistant/developers.home-assistant#912 |
…rations-without-version
Breaking change
As mentioned in every release since 2021.3, custom integrations will require a version key in their manifest file.
If that key is missing, the custom integration will no longer be loaded.
For more details see https://developers.home-assistant.io/blog/2021/01/29/custom-integration-changes#versions
Proposed change
The last part of the plan outlined in https://developers.home-assistant.io/blog/2021/01/29/custom-integration-changes#versions. With this custom integrations that are missing the version key, or have an invalid version key will no longer be loaded.
That also means that legacy integrations will not load with this, since those do not have a manifest file.
Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: