Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DSMR: Remove Gas derivative sensor #52147

Merged
merged 1 commit into from
Jun 24, 2021
Merged

DSMR: Remove Gas derivative sensor #52147

merged 1 commit into from
Jun 24, 2021

Conversation

frenck
Copy link
Member

@frenck frenck commented Jun 24, 2021

Breaking change

The Hourly Gas Consumption sensor has been removed from the DSMR integration.
This sensor was calculated and it is not an actual datapoint from the energy meter.

If you are looking for a replacement, you can use the Derivative integration to re-create the hourly (or any other timeframe)
sensor based on the total Gas consumption sensor.

Proposed change

This PR removes the hourly gas consumption sensor from the DSMR integration, as it was a calculated/virtual sensor that doesn't originate from the device/service the integration is connected to.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link

Hey there @RobBie1221, mind taking a look at this pull request as its been labeled with an integration (dsmr) you are listed as a codeowner for? Thanks!
(message by CodeOwnersMention)

@frenck frenck merged commit afa00b7 into dev Jun 24, 2021
@frenck frenck deleted the frenck-2021-1857 branch June 24, 2021 12:25
@github-actions github-actions bot locked and limited conversation to collaborators Jun 25, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants