-
-
Notifications
You must be signed in to change notification settings - Fork 30.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Store JSON in database in compact format #53364
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice.
this will only impact new events and states that get recorded right? Is it worth doing a migration as part of this? Perhaps not since the old data should age out over time |
I think its best not to re-write history if we can avoid it since you are only saving 3-7% and having to pay a large I/O & cpu cost. Probably best to let it expire over time |
This will break some of the logbook optimizations (we jump through some hoops to avoid de-serializing JSON since we could end up with 200-millions of json deserialize calls per logbook api call) but should be trivial to fix.
|
WUT?! haha |
Yeah..... I'd rather we could normalize more of data in the database instead of |
Proposed change
A great observation from @slovdahl reported on Discord:
This PR compacts the JSON a bit, thanks @slovdahl ❤️
Result:
Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: