Rework octoprint #58040
Merged
Rework octoprint #58040
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
22 tasks
|
For a PR this size, we should probably have more of a description than:
|
MartinHjelmare
force-pushed
the
rework-octoprint
branch
from
c638b45
to
d4acfb1
Compare
|
I've rebased the rework-octoprint branch on latest dev just now. |
|
Please fix the failing tests and add the missing config flow tests in a new PR targeting rework-octoprint branch. |
Co-authored-by: Martin Hjelmare <marhje52@gmail.com>
* Bump library version to 1.6 to fix header usages * Add already configured tests for ssdp, zeroconf, and user * Set ssl value correctly on the form when an error occurs * Test fixes
MartinHjelmare
force-pushed
the
rework-octoprint
branch
from
7f088ef
to
0856db2
Compare
22 tasks
…58190) * Mark printer entities unavailable when printer is offline * Fixing code review comments * Fix printer offline status and unit test typing
MartinHjelmare
approved these changes
Oct 21, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking change
The OctoPrint integration migrated to configuration via the UI. Configuring OctoPrint via YAML configuration has been deprecated and will be removed in a future Home Assistant release.
Your existing YAML configuration is automatically imported on upgrade to this release; and thus can be safely removed from your YAML configuration after upgrading.
Sensors removed:
Sensors added:
Previously entities added would be prefixed by the printer name, i.e. if the printer was ender 5, the sensors would be
sensor.ender_5_bed_temp0. After this change they will besensor.octoprint_bed_temp0and can be renamed.Proposed change
Updating octoprint integration to use library to handle the API and adding a config_flow.
Previous PRs for the initial two commits:
#46432
#46611
Type of change
Additional information
First two commits were reviewed before merge into rework-octoprint.
Following commits are to resolve issues after the rebase.
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: