Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add instant arming for totalconnect #60156

Merged
merged 9 commits into from
Dec 12, 2021
Merged

Add instant arming for totalconnect #60156

merged 9 commits into from
Dec 12, 2021

Conversation

austinmroczek
Copy link
Contributor

@austinmroczek austinmroczek commented Nov 22, 2021 •
edited
Loading

Proposed change

Adds instant arm away/stay for TotalConnect so alarms trigger instantly if a door is opened.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • [n/a] New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • [n/a] For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • [n/a] Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

austinmroczek added a commit to austinmroczek/home-assistant.github.io that referenced this pull request Dec 7, 2021
@austinmroczek
Update totalconnect.markdown
73e748d 
Add info about the arm_away_instant and arm_stay_instant services provided by home-assistant/core#60156
@austinmroczek austinmroczek mentioned this pull request Dec 7, 2021
Merged
8 tasks
@austinmroczek austinmroczek marked this pull request as ready for review December 7, 2021 05:53
bdraco
bdraco requested changes Dec 7, 2021
View reviewed changes
Copy link
Member

@bdraco bdraco left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

-dupe-

bdraco
bdraco requested changes Dec 7, 2021
View reviewed changes
Copy link
Member

@bdraco bdraco left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, unless arm_stay isn't the same as arm_home, lets keep it consistent with arm_home https://developers.home-assistant.io/docs/core/entity/alarm-control-panel/#alarm-arm-home since it supports SUPPORT_ALARM_ARM_HOME

@austinmroczek
Copy link
Contributor Author

I'll get it switched to 'home'. Sorry 'stay' is the TotalConnect wording

austinmroczek and others added 4 commits December 11, 2021 10:10
@austinmroczek @bdraco
Update homeassistant/components/totalconnect/alarm_control_panel.py
d23e132 
Co-authored-by: J. Nick Koston <nick@koston.org>
@austinmroczek @bdraco
Update homeassistant/components/totalconnect/services.yaml
52698c3 
Co-authored-by: J. Nick Koston <nick@koston.org>
@austinmroczek @bdraco
Update homeassistant/components/totalconnect/services.yaml
b17e9dd 
Co-authored-by: J. Nick Koston <nick@koston.org>
@austinmroczek @bdraco
Update homeassistant/components/totalconnect/services.yaml
f440e7c 
Co-authored-by: J. Nick Koston <nick@koston.org>
@austinmroczek
Copy link
Contributor Author

@bdraco I made the changes requested, thanks for the review

@bdraco bdraco merged commit 3198211 into home-assistant:dev Dec 12, 2021
MartinHjelmare
MartinHjelmare reviewed Dec 12, 2021
View reviewed changes
Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please address the comment in a new PR. Thanks!

homeassistant/components/totalconnect/alarm_control_panel.py Show resolved Hide resolved
@austinmroczek austinmroczek deleted the instant_arm branch December 12, 2021 17:33
@austinmroczek austinmroczek mentioned this pull request Dec 12, 2021
Merged
20 tasks
@github-actions github-actions bot locked and limited conversation to collaborators Dec 13, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MartinHjelmare MartinHjelmare MartinHjelmare left review comments

@bdraco bdraco bdraco approved these changes

Assignees
No one assigned
Labels
by-code-owner cla-signed integration: totalconnect new-feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unable to set Instant Stay Arming with TotalConnect Integration
4 participants
@austinmroczek @bdraco @MartinHjelmare @homeassistant