Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow binary sensor state to be None #60193

Merged
merged 14 commits into from
Dec 22, 2021
Merged

Allow binary sensor state to be None #60193

merged 14 commits into from
Dec 22, 2021

Conversation

frenck
Copy link
Member

@frenck frenck commented Nov 23, 2021

Breaking change

Previously, binary_sensor entities could have the state on or off, and in case the device was unreachable: unavailable. However, compared to other entities, it wasn't able to have the unknown state, which has been added.

So, a binary_sensor entity can now have the on, off, unavailable, or unknown state.

You might need to adapt your automations or scripts to take this new unknown state into account.

Proposed change

Binary sensors currently cannot have a None state value (which translates to an "unknown" state). This PR adjusts that.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

Copy link
Contributor

@elupus elupus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good i think. At least from rfxtrx perspective.

@frenck
Copy link
Member Author

frenck commented Dec 22, 2021

Rebased to deal with a merge conflict in the tasmota integration

@MartinHjelmare MartinHjelmare merged commit 60b2cdd into dev Dec 22, 2021
@MartinHjelmare MartinHjelmare deleted the frenck-2021-3058 branch December 22, 2021 11:24
@github-actions github-actions bot locked and limited conversation to collaborators Dec 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants