-
-
Notifications
You must be signed in to change notification settings - Fork 30.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add UniFi Protect media_player #62895
Conversation
Hey there @briis, @bdraco, mind taking a look at this pull request as it has been labeled with an integration ( |
Can you add just one platform at a time (either |
This comment was marked as abuse.
This comment was marked as abuse.
You should really also move the changes to the camera tests to another PR if you can - though I am not sure if you can do so without creating a conflict. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please see comments above
When you bump a dep in a PR it’s required to add a link to the change log of the dep |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks 👍
While home-assistant/home-assistant.io#20851 LGTM, I'm keeping track of which platforms need to be added since I want to give other reviews a chance to respond before merging. |
Proposed change
Second PR for migrating HACS integration for UniFi Protect. Adds the
media_player
platforms.Previous PRs:
Following the advice of @bdraco, these PRs will be broken up into smaller PRs to make them easier to review and merge:
pyunifiprotect changes: https://github.com/briis/pyunifiprotect/compare/v1.4.4..v1.4.7
Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: