Ensure service calls are typed [k-n] #62917
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
epenet
requested review from
cgtobi,
Danielhiversen,
emontnemery and
a team
as code owners
epenet
commented
Dec 28, 2021
| @@ -67,12 +70,14 @@ async def async_setup_entry(hass: HomeAssistant, entry: ConfigEntry) -> bool: | |||
| _LOGGER.error("Error occurred during Mazda login request: %s", ex) | |||
| raise ConfigEntryNotReady from ex | |||
|
|
|||
| async def async_handle_service_call(service_call=None): | |||
| async def async_handle_service_call(service_call: ServiceCall) -> None: | |||
There was a problem hiding this comment.
The previous type hint was wrong.
Comment on lines
79
to
80
| if TYPE_CHECKING: | ||
| assert device_entry |
There was a problem hiding this comment.
It has already been checked in the schema validation (validate_mazda_device_id)
core/homeassistant/components/mazda/__init__.py
Lines 115 to 116 in 41c497e
frenck
reviewed
Dec 28, 2021
Comment on lines
+79
to
+81
| if TYPE_CHECKING: | ||
| # For mypy: it has already been checked in validate_mazda_device_id | ||
| assert device_entry |
There was a problem hiding this comment.
I don't like these kinds of concepts.
The fact is, async_get may return None; which should just be handled; not silenced.
There was a problem hiding this comment.
I don't like it either, and I originally planned to raise a ValueError.
But then I noticed it was already handled inside the schema validation process.
MartinHjelmare
approved these changes
Dec 28, 2021
22 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: