Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add configuration flow to CPU Speed #62929

Merged
merged 1 commit into from
Dec 28, 2021
Merged

Add configuration flow to CPU Speed #62929

merged 1 commit into from
Dec 28, 2021

Conversation

frenck
Copy link
Member

@frenck frenck commented Dec 28, 2021

Breaking change

The CPU Speed integration migrated to configuration via the UI. Configuring CPU Speed via YAML configuration has been deprecated and will be removed in a future Home Assistant release.

Your existing YAML configuration is automatically imported on upgrade to this release; and thus can be safely removed from your YAML configuration after upgrading.

Proposed change

This PR implements the bare minimum configuration flow for the CPU Speed integration, including import.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link

Hey there @fabaff, mind taking a look at this pull request as it has been labeled with an integration (cpuspeed) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@frenck frenck marked this pull request as ready for review December 28, 2021 13:06
@frenck frenck requested a review from fabaff as a code owner December 28, 2021 13:06
@@ -0,0 +1,14 @@
{
"title": "CPU Speed",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"title": "CPU Speed",

Not needed since its the same as the manifest

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Incorrect, this is an integration that is perfectly fit for offering translation on the title.

}
}
},
"title": "CPU Speed"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"title": "CPU Speed"

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above

@bdraco
Copy link
Member

bdraco commented Dec 28, 2021

Should this abort if the install type is in a container ?

@frenck
Copy link
Member Author

frenck commented Dec 28, 2021

Should this abort if the install type is in a container ?

Maybe, I'm looking at those cases in the next steps.

@frenck frenck merged commit 5ab527e into dev Dec 28, 2021
@frenck frenck deleted the frenck-2021-3363 branch December 28, 2021 20:17
@bdraco
Copy link
Member

bdraco commented Dec 28, 2021

Should this abort if the install type is in a container ?

Maybe, I'm looking at those cases in the next steps.

In case its mildly helpful, this is what usb is using

        info = await system_info.async_get_system_info(self.hass)
        if info.get("docker"):
            return

@github-actions github-actions bot locked and limited conversation to collaborators Dec 29, 2021
}
},
"abort": {
"alread_configured": "[%key:common::config_flow::abort::single_instance_allowed%]"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

already_configured

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 #63284

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants