Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add type hints to nissan_leaf integration #62967

Merged
merged 6 commits into from
Dec 29, 2021

Conversation

filcole
Copy link
Contributor

@filcole filcole commented Dec 28, 2021

Proposed change

Use type hints for nissan_leaf component. I'm new to python typing so improvements gratefully accepted!

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@filcole filcole changed the title Nisssanleaf functiontypehints Add type hints to nissan_leaf integration Dec 28, 2021
@chemelli74
Copy link
Contributor

Hi @filcole, thx for your contribution!

To fully enable strict typing please consider also to:

  1. add nissan_leaf to .strict-typing file
  2. run "python3 -m script.hassfest"
  3. run "mypy homeassistant/components/nissan_leaf"

Simone

@filcole
Copy link
Contributor Author

filcole commented Dec 28, 2021

Thanks @chemelli74 - really helpful, adding to .strict-typing makes mypy much more helpful.

@filcole filcole marked this pull request as ready for review December 29, 2021 00:08
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @filcole 👍

@frenck frenck merged commit 54d1e20 into home-assistant:dev Dec 29, 2021
@filcole filcole deleted the nisssanleaf_functiontypehints branch December 29, 2021 20:52
@github-actions github-actions bot locked and limited conversation to collaborators Dec 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants