-
-
Notifications
You must be signed in to change notification settings - Fork 30.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve nest camera failure handling on removal #63207
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
probot-home-assistant
bot
added
bugfix
has-tests
integration: nest
small-pr
PRs with less than 30 lines.
labels
Jan 2, 2022
allenporter
changed the title
Improve nest camera when removed
Improve nest camera failure handling on removal
Jan 2, 2022
davet2001
reviewed
Jan 2, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, one possible improvement.
allenporter
added a commit
to allenporter/python-google-nest-sdm
that referenced
this pull request
Jan 2, 2022
Make AuthExceptiond drive from ApiException to have error handling be simplified upstream only cathcing a single exception more narrow than GoogleNestException. Follow on from discussion in home-assistant/core#63207
allenporter
added a commit
to allenporter/python-google-nest-sdm
that referenced
this pull request
Jan 2, 2022
Make AuthException subclass ApiException for improved exception catching in Home Assistant. Currently ApiException and AuthException can be thrown in the API calls, where it currently catches the more broad GoogleNestException. Follow on from discussion in home-assistant/core#63207
This was referenced Jan 2, 2022
Add failure handling when stopping a camera stream when a camera entity is removed by swallowing the exception. A camera stream is exentually expired anyway, so it is safe to ignore the failure and rely on expiration. Discovered failures here when exercising home-assistant#62976 on a dev build where revoking camera permissions would reload the integration, causing it to fail because Home Assistant no longer had permission to stop the camera.
Use more narrow exception following home-assistant#63225
davet2001
approved these changes
Jan 2, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, but the test should have a second review by someone with more experience than me!
frenck
added
the
smash
Indicator this PR is close to finish for merging or closing
label
Jan 3, 2022
frenck
approved these changes
Jan 5, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
bugfix
by-code-owner
cla-signed
has-tests
integration: nest
small-pr
PRs with less than 30 lines.
smash
Indicator this PR is close to finish for merging or closing
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Add failure handling when stopping a camera stream when a camera entity is
removed by swallowing the exception. A camera stream is exentually expired
anyway, so it is safe to ignore the failure and rely on expiration.
Discovered failures here when exercising #62976 on a dev build where revoking camera permissions would reload the integration, causing it to fail because
Home Assistant no longer had permission to stop the camera.
Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: