-
-
Notifications
You must be signed in to change notification settings - Fork 30.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add type hints to async_setup_scanner #63826
Conversation
Hey there @Quentame, @nzapponi, mind taking a look at this pull request as it has been labeled with an integration ( |
Hey there @ludeeus, mind taking a look at this pull request as it has been labeled with an integration ( |
Hey there @molobrakos, @decompil3d, mind taking a look at this pull request as it has been labeled with an integration ( |
config: ConfigType, | ||
async_see: Callable[..., Awaitable[None]], | ||
discovery_info: DiscoveryInfoType | None = None, | ||
) -> None: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The return value typing is incorrect. It should be True on success. We'll need to update the code too, to properly handle a boolean return value:
setup = await self.platform.async_setup_scanner( |
if setup is None and scanner is None: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aaargh :(
Stupid tracker platform
This reverts commit c6aaa24.
Proposed change
Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: