Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pin python-engineio and python-socketio #64074

Merged
merged 1 commit into from
Jan 14, 2022

Conversation

cdce8p
Copy link
Member

@cdce8p cdce8p commented Jan 13, 2022

Proposed change

Prevent potential dependency conflicts between sisyphus-control and aioambient.

Current bounds from aioambient: https://github.com/bachya/aioambient/blob/2021.11.0/pyproject.toml#L63-L64

python-engineio = ">=3.13.1,<5.0.0"
python-socketio = ">=4.6,<6.0"

Current bounds from sisyphus-control: https://github.com/jkeljo/sisyphus-control/blob/v3.1.2/setup.py#L34-L35
See also: jkeljo/sisyphus-control#6

"python-socketio>=4.0,<5.0"
"python-engineio>=3.0,<4.0"

This will help resolve a conflict from pip check: #64058

sisyphus-control 3.1.2 has requirement python-engineio<4.0,>=3.0, but you have python-engineio 4.3.1.
sisyphus-control 3.1.2 has requirement python-socketio<5.0,>=4.0, but you have python-socketio 5.5.1.

/CC: @bachya @jkeljo

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

Prevent potential dependency conflicts between sisyphus-control and aioambient
@jkeljo
Copy link
Contributor

jkeljo commented Jan 13, 2022

This is fine by me. sisyphus_control unfortunately can't go higher because those versions force usage of a newer version of the Socket.IO protocol than what the Sisyphus devices can speak.

Copy link
Contributor

@bachya bachya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed that functionally, the Ambient integration works with this change. 👍🏻

@cdce8p
Copy link
Member Author

cdce8p commented Jan 13, 2022

Thanks for testing! I mentioned it here already, for now the pinning does work. It might not in the future though.
python-socketio doesn't help with their supported protocol versions. For Home Assistant it would have been better to have dedicated packages for each incompatible version.

@thecode thecode merged commit c6acd8e into home-assistant:dev Jan 14, 2022
@cdce8p cdce8p deleted the dep-socketio branch January 14, 2022 08:48
@cdce8p cdce8p mentioned this pull request Jan 14, 2022
22 tasks
@github-actions github-actions bot locked and limited conversation to collaborators Jan 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants