-
-
Notifications
You must be signed in to change notification settings - Fork 30.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump python-kasa to 0.4.1 for tplink integration #64123
Conversation
Hey there @TheGardenMonkey, mind taking a look at this pull request as it has been labeled with an integration ( |
Hmm, looks like fixing those mypy issues is not that straightforward and I'll have to rethink how to pull that off, so I'll convert this into a draft as I won't be having time to investigate this before February... |
We can probably use generics in some places to fix this |
python-kasa/python-kasa#289 fixes the first one, but perhaps the |
31ecebc
to
6821b84
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's merge this and bump again to fix the .close()
typing in the next turn.
Thanks for fixing the tests @bdraco! I see no reason why this couldn't be merged assuming those casts are acceptable :-) |
It seems that this bump has fixes upstream, any reason for this not to be tagged for the milestone of 2022.2 @rytilahti @bdraco ? |
No reason not to include this in the release in my opinion so I added the label. |
Co-authored-by: J. Nick Koston <nick@koston.org>
Proposed change
Bump python-kasa to the newest upstream release.
Changelog available at https://github.com/python-kasa/python-kasa/releases/tag/0.4.1
Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: