Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump python-kasa to 0.4.1 for tplink integration #64123

Merged
merged 2 commits into from
Jan 31, 2022

Conversation

rytilahti
Copy link
Member

@rytilahti rytilahti commented Jan 14, 2022

Proposed change

Bump python-kasa to the newest upstream release.
Changelog available at https://github.com/python-kasa/python-kasa/releases/tag/0.4.1

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link

Hey there @TheGardenMonkey, mind taking a look at this pull request as it has been labeled with an integration (tplink) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@rytilahti rytilahti marked this pull request as ready for review January 14, 2022 15:55
@rytilahti
Copy link
Member Author

Hmm, looks like fixing those mypy issues is not that straightforward and I'll have to rethink how to pull that off, so I'll convert this into a draft as I won't be having time to investigate this before February...

@rytilahti rytilahti marked this pull request as draft January 14, 2022 16:49
@bdraco
Copy link
Member

bdraco commented Jan 29, 2022

We can probably use generics in some places to fix this

@rytilahti
Copy link
Member Author

python-kasa/python-kasa#289 fixes the first one, but perhaps the SmartDevice should define the APIs used by the lights? Or SmartLightStrip could implement the SmartBulb's interface, I'm not sure what's the best approach here.

@rytilahti rytilahti marked this pull request as ready for review January 31, 2022 02:08
Copy link
Member

@bdraco bdraco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's merge this and bump again to fix the .close() typing in the next turn.

@bdraco bdraco merged commit c985ebb into home-assistant:dev Jan 31, 2022
@rytilahti
Copy link
Member Author

Thanks for fixing the tests @bdraco! I see no reason why this couldn't be merged assuming those casts are acceptable :-)

@rytilahti rytilahti deleted the tplink/bump_kasa_041 branch January 31, 2022 02:10
@frenck
Copy link
Member

frenck commented Jan 31, 2022

It seems that this bump has fixes upstream, any reason for this not to be tagged for the milestone of 2022.2 @rytilahti @bdraco ?

@rytilahti rytilahti added this to the 2022.2.0 milestone Jan 31, 2022
@rytilahti
Copy link
Member Author

No reason not to include this in the release in my opinion so I added the label.

balloob pushed a commit that referenced this pull request Feb 1, 2022
Co-authored-by: J. Nick Koston <nick@koston.org>
@github-actions github-actions bot locked and limited conversation to collaborators Feb 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Unknown color temperature range, fallback to 2700-5000" being logged every 10 seconds
6 participants