Bump google-nest-sdm to 1.5.0 and add nest mp4 clip transcoding to animated gif #64155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reference a thumbnail version of the media for rendering in the grid. This requires PR home-assistant/frontend#10978 in order to ensure media is loaded with the right authentication.
Add support for nest mp4 clips to transcode to mp4. This uses the ffmpeg component to get the ffmpeg binary and hand off to the Nest SDM library that handles transcoding and caching in the media store. Gifs are only created on demand, and only allows one clip transcode at once, to ensure things don't go wild doing transcoding. Its still fairly performant and increases disk storage by about 20% for each clip.
balloob
approved these changes
Jan 15, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Transcode nest mp4 clips to animated gifs so they can be rendered as thumbnails in the media player and used for mobile notifications for android which doesn't support mp4 video.
The
ffmpegcomponent is used to provide the ffmpeg binary to the sdm library, which handles the transcoding. Transcoding is handled on demand when rendering the grid, with a limit of one transcode item at a time to throttle load.The ffmpeg work is similar to the haffmpeg library, though it reads and writes directly to files in the media store. Gifs are also slowed a little bit so the 10 frames are spread out at the same speed as shown in the Nest or Google Home app, and they are looped.
allenporter/python-google-nest-sdm@1.4.0...1.5.0 - contains transcoding feature.
Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: