Add device registry cleanup to github #64380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
probot-home-assistant
bot
added
has-tests
integration: github
new-feature
small-pr
|
Hey there @timmo001, mind taking a look at this pull request as it has been labeled with an integration ( |
balloob
reviewed
Jan 18, 2022
balloob
approved these changes
Jan 18, 2022
| hass.config_entries.async_setup_platforms(entry, PLATFORMS) | ||
| entry.async_on_unload(entry.add_update_listener(async_reload_entry)) | ||
|
|
||
| return True | ||
|
|
||
|
|
||
| async def async_cleanup_device_registry( |
There was a problem hiding this comment.
This can be a @callback since we don't await inside.
| ) | ||
|
|
||
| assert registry.async_get_device({(DOMAIN, "test/repository")}) == device | ||
| await async_cleanup_device_registry(hass, mock_config_entry) |
There was a problem hiding this comment.
Don't call the function directly. Set up the integration with the problem case and then assert that the device registry state is adjusted correctly.
There was a problem hiding this comment.
Will address this when the diagnostics PR is merged since that adds a fixture for the setup
22 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking change
Proposed change
When a user removes a repository from the list of repositories we need to remove the device for it.
Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: