Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move install_requires to setup.cfg #65095

Merged
merged 1 commit into from
Jan 28, 2022

Conversation

cdce8p
Copy link
Member

@cdce8p cdce8p commented Jan 27, 2022

Proposed change

Related to #65091
This PR moves the install_requires key from setup.py to setup.cfg.

https://setuptools.pypa.io/en/latest/userguide/dependency_management.html#declaring-required-dependency

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@cdce8p cdce8p requested a review from a team as a code owner January 27, 2022 23:57
@probot-home-assistant probot-home-assistant bot added code-quality small-pr PRs with less than 30 lines. labels Jan 27, 2022
@balloob
Copy link
Member

balloob commented Jan 28, 2022

Shouldn't we move to pyproject.toml? That seems to be the future.

@balloob balloob merged commit 86ed720 into home-assistant:dev Jan 28, 2022
@cdce8p cdce8p deleted the setup_install-requires branch January 28, 2022 11:21
@cdce8p
Copy link
Member Author

cdce8p commented Jan 28, 2022

Shouldn't we move to pyproject.toml? That seems to be the future.

Setuptools doesn't yet support pyproject.toml. There is an open PR, but it seems like that isn't quite ready.

@cdce8p cdce8p mentioned this pull request Jan 28, 2022
22 tasks
@balloob balloob added this to the 2022.2.0 milestone Jan 28, 2022
balloob pushed a commit that referenced this pull request Jan 29, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Jan 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants