Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move remaining keys to setup.cfg #65154

Merged
merged 6 commits into from
Jan 29, 2022
Merged

Conversation

cdce8p
Copy link
Member

@cdce8p cdce8p commented Jan 28, 2022

Proposed change

Complete the move from setup.py to setup.cfg.
Depends on #65145, since this PR removes setup.py completely and thus python setup.py sdist bdist_wheel won't work.

Additional improvements

Full list of files which won't be included with these changes (compared to what is included now)!
script/__init__.py
script/gen_requirements_all.py
script/inspect_schemas.py
script/lazytox.py
script/version_bump.py
script/hassfest/__init__.py
script/hassfest/__main__.py
script/hassfest/codeowners.py
script/hassfest/config_flow.py
script/hassfest/coverage.py
script/hassfest/dependencies.py
script/hassfest/dhcp.py
script/hassfest/json.py
script/hassfest/manifest.py
script/hassfest/manifest_helper.py
script/hassfest/metadata.py
script/hassfest/model.py
script/hassfest/mqtt.py
script/hassfest/mypy_config.py
script/hassfest/requirements.py
script/hassfest/services.py
script/hassfest/ssdp.py
script/hassfest/translations.py
script/hassfest/usb.py
script/hassfest/zeroconf.py
script/scaffold/__init__.py
script/scaffold/__main__.py
script/scaffold/const.py
script/scaffold/docs.py
script/scaffold/error.py
script/scaffold/gather_info.py
script/scaffold/generate.py
script/scaffold/model.py
script/translations/__init__.py
script/translations/__main__.py
script/translations/clean.py
script/translations/const.py
script/translations/develop.py
script/translations/download.py
script/translations/error.py
script/translations/frontend.py
script/translations/lokalise.py
script/translations/migrate.py
script/translations/upload.py
script/translations/util.py

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

* Remove unused constants
* Remove deprecated test_suite key
* Only include homeassistant*, not script*
* Add long_desc_content_type
* Remove license file (auto-included by setuptools + wheels)
@cdce8p cdce8p requested a review from a team as a code owner January 28, 2022 21:51
@probot-home-assistant probot-home-assistant bot added the small-pr PRs with less than 30 lines. label Jan 28, 2022
Copy link
Member

@balloob balloob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@cdce8p
Copy link
Member Author

cdce8p commented Jan 29, 2022

I did some more testing to make sure everything still works as expected. Turns out we can't remove setup.py just yet. Support for editable installs with build-backends was only added in pip 21.3. So we need to keep it around a bit longer. Besides that, I didn't notice anything unusual. Since #65145 has been merged, this would also be good to go.

Not required, but I would suggest to cherry-pick it, too. That way we do all of them together.

I don't expect any issues, but if someone still encounters any, please let me know. I should be able to help.

@cdce8p cdce8p mentioned this pull request Jan 29, 2022
43 tasks
@balloob balloob added this to the 2022.2.0 milestone Jan 29, 2022
@balloob balloob merged commit c7cdee2 into home-assistant:dev Jan 29, 2022
@cdce8p cdce8p deleted the remove-setup branch January 29, 2022 04:21
balloob pushed a commit that referenced this pull request Jan 29, 2022
* Move metadata keys

* Move options

* Delete setup.py

* Remove unused constants
* Remove deprecated test_suite key

* Improve metadata

* Only include homeassistant*, not script*
* Add long_desc_content_type
* Remove license file (auto-included by setuptools + wheels)

* Add setup.py

Pip 21.2 doesn't support editable installs without it.
@github-actions github-actions bot locked and limited conversation to collaborators Jan 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cherry-picked cla-signed small-pr PRs with less than 30 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants