Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add diagnostics support to Fritz #65334

Merged

Conversation

chemelli74
Copy link
Contributor

@chemelli74 chemelli74 commented Jan 31, 2022

Proposed change

Add diagnostics support to Fritz

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link

Hey there @mammuth, @AaronDavidSchneider, @mib1185, mind taking a look at this pull request as it has been labeled with an integration (fritz) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

Copy link
Contributor

@mib1185 mib1185 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The diagnostics download itself works great ✅
example diag data:

{
  "home_assistant": {...},
  "custom_components": {...},
  "integration_manifest": {
    "domain": "fritz",
    "name": "AVM FRITZ!Box Tools",
    "documentation": "https://www.home-assistant.io/integrations/fritz",
    "requirements": [
      "fritzconnection==1.8.0",
      "xmltodict==0.12.0"
    ],
    "dependencies": [
      "network"
    ],
    "codeowners": [
      "@mammuth",
      "@AaronDavidSchneider",
      "@chemelli74",
      "@mib1185"
    ],
    "config_flow": true,
    "ssdp": [
      {
        "st": "urn:schemas-upnp-org:device:fritzbox:1"
      }
    ],
    "iot_class": "local_polling",
    "loggers": [
      "fritzconnection"
    ],
    "is_built_in": true
  },
  "data": {
    "entry": {
      "entry_id": "35b5195b73e7bf2295de44d5fdc8e47a",
      "version": 1,
      "domain": "fritz",
      "title": "FRITZ!Box 7530 AX",
      "data": {
        "host": "192.168.1.1",
        "password": "**REDACTED**",
        "port": 49000,
        "username": "**REDACTED**"
      },
      "options": {
        "consider_home": 5
      },
      "pref_disable_new_entities": false,
      "pref_disable_polling": false,
      "source": "user",
      "unique_id": null,
      "disabled_by": null
    },
    "device_info": {
      "model": "FRITZ!Box 7530 AX",
      "current firmware": "256.07.29",
      "latest firmware": "",
      "update available": false,
      "is router": true,
      "mesh role": "master",
      "last update success": true,
      "last exception": null
    }
  }
}

But getting the tests working requires a lot more effort and love , since it is the first time for this integration, that the whole configuration entry setup needs to be mocked, which needs the login, gatting device-info, gathering available services, getting host-infos and connected clients,...

@mib1185 mib1185 added this to the 2022.2.0 milestone Jan 31, 2022
@chemelli74 chemelli74 marked this pull request as ready for review January 31, 2022 22:32
@chemelli74 chemelli74 merged commit a9af29c into home-assistant:dev Jan 31, 2022
@chemelli74 chemelli74 deleted the chemelli74-fritz-diagnostics branch January 31, 2022 22:43
balloob pushed a commit that referenced this pull request Feb 1, 2022
* Add diagnostics support to Fritz

* Temporary remove tests

* coveragerc
@github-actions github-actions bot locked and limited conversation to collaborators Feb 2, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants