-
-
Notifications
You must be signed in to change notification settings - Fork 30.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add diagnostics support to Fritz #65334
Add diagnostics support to Fritz #65334
Conversation
Hey there @mammuth, @AaronDavidSchneider, @mib1185, mind taking a look at this pull request as it has been labeled with an integration ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The diagnostics download itself works great ✅
example diag data:
{
"home_assistant": {...},
"custom_components": {...},
"integration_manifest": {
"domain": "fritz",
"name": "AVM FRITZ!Box Tools",
"documentation": "https://www.home-assistant.io/integrations/fritz",
"requirements": [
"fritzconnection==1.8.0",
"xmltodict==0.12.0"
],
"dependencies": [
"network"
],
"codeowners": [
"@mammuth",
"@AaronDavidSchneider",
"@chemelli74",
"@mib1185"
],
"config_flow": true,
"ssdp": [
{
"st": "urn:schemas-upnp-org:device:fritzbox:1"
}
],
"iot_class": "local_polling",
"loggers": [
"fritzconnection"
],
"is_built_in": true
},
"data": {
"entry": {
"entry_id": "35b5195b73e7bf2295de44d5fdc8e47a",
"version": 1,
"domain": "fritz",
"title": "FRITZ!Box 7530 AX",
"data": {
"host": "192.168.1.1",
"password": "**REDACTED**",
"port": 49000,
"username": "**REDACTED**"
},
"options": {
"consider_home": 5
},
"pref_disable_new_entities": false,
"pref_disable_polling": false,
"source": "user",
"unique_id": null,
"disabled_by": null
},
"device_info": {
"model": "FRITZ!Box 7530 AX",
"current firmware": "256.07.29",
"latest firmware": "",
"update available": false,
"is router": true,
"mesh role": "master",
"last update success": true,
"last exception": null
}
}
}
But getting the tests working requires a lot more effort and love , since it is the first time for this integration, that the whole configuration entry setup needs to be mocked, which needs the login, gatting device-info, gathering available services, getting host-infos and connected clients,...
* Add diagnostics support to Fritz * Temporary remove tests * coveragerc
Proposed change
Add diagnostics support to Fritz
Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: