Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ZHA presets for Siterwell TRVs #68145

Closed
wants to merge 1 commit into from
Closed

Add ZHA presets for Siterwell TRVs #68145

wants to merge 1 commit into from

Conversation

MattWestb
Copy link
Contributor

Adding presets for all known Siterwell TRVs that is supported in ZHA.
tuya TRV Matrix zigpy/zigpy#653 (comment)

Breaking change

Only if the user is using climate On/Off mode that is not supported by this devices (its always on and shall using away / frost protection presets instead).

Proposed change

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

Adding presets for all known Siterwell TRVs that is supported in ZHA.
tuya TRV Matrix zigpy/zigpy#653 (comment)
@probot-home-assistant
Copy link

Hey there @dmulcahey, @Adminiuga, mind taking a look at this pull request as it has been labeled with an integration (zha) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@MattWestb
Copy link
Contributor Author

Shall being merged with zigpy/zha-device-handlers#1192 then user have using there devices for over one year and is loosing the possibility changing working mode in ZHA and must have the presets for doing it in the new right way.

Copy link
Contributor

@Adminiuga Adminiuga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can be merged once the checks pass. Lgtm

@MartinHjelmare MartinHjelmare changed the title Adding ZHA presets for Siterwell TRVs Add ZHA presets for Siterwell TRVs Mar 15, 2022
@MattWestb
Copy link
Contributor Author

Thanks Alexei but i dont have the knowledge fixing the the tests then im not one code warier :-(((

@github-actions
Copy link

There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days.
Thank you for your contributions.

@github-actions github-actions bot added the stale label Apr 14, 2022
@MattWestb
Copy link
Contributor Author

Thanks !!

@github-actions github-actions bot removed the stale label Apr 14, 2022
@dmulcahey
Copy link
Contributor

You need to do this same thing: #59289 (comment) for this PR too

@MattWestb
Copy link
Contributor Author

Im very sorry but both TRVs (or more true all tuya MCU zigbee device) is using one generic tuya MCU zigbee module with the same cluster (is 2 models one old and one new) so the device have the same signature only the manufacture name and model is changed.

@github-actions
Copy link

There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days.
Thank you for your contributions.

@github-actions github-actions bot added the stale label Jul 24, 2022
@MattWestb
Copy link
Contributor Author

All tuya TS0601 devices is having the same zigbee modules = the same signature but different tuya MCU that is not doing anything with the zigbee signature only the commands tunneled thru the tuya MCU cluster so i think its needles doing it for more devices.

And the PR #59289 is dead then asked question is not answered of the code owner.

@github-actions github-actions bot removed the stale label Jul 24, 2022
@MattWestb MattWestb closed this by deleting the head repository Dec 28, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Dec 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants