-
-
Notifications
You must be signed in to change notification settings - Fork 30.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ZHA presets for Siterwell TRVs #68145
Conversation
Adding presets for all known Siterwell TRVs that is supported in ZHA. tuya TRV Matrix zigpy/zigpy#653 (comment)
Hey there @dmulcahey, @Adminiuga, mind taking a look at this pull request as it has been labeled with an integration ( |
Shall being merged with zigpy/zha-device-handlers#1192 then user have using there devices for over one year and is loosing the possibility changing working mode in ZHA and must have the presets for doing it in the new right way. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can be merged once the checks pass. Lgtm
Thanks Alexei but i dont have the knowledge fixing the the tests then im not one code warier :-((( |
There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days. |
Thanks !! |
You need to do this same thing: #59289 (comment) for this PR too |
Im very sorry but both TRVs (or more true all tuya MCU zigbee device) is using one generic tuya MCU zigbee module with the same cluster (is 2 models one old and one new) so the device have the same signature only the manufacture name and model is changed. |
There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days. |
All tuya TS0601 devices is having the same zigbee modules = the same signature but different tuya MCU that is not doing anything with the zigbee signature only the commands tunneled thru the tuya MCU cluster so i think its needles doing it for more devices. And the PR #59289 is dead then asked question is not answered of the code owner. |
Adding presets for all known Siterwell TRVs that is supported in ZHA.
tuya TRV Matrix zigpy/zigpy#653 (comment)
Breaking change
Only if the user is using climate On/Off mode that is not supported by this devices (its always on and shall using away / frost protection presets instead).
Proposed change
Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: