Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add parametrizable analog input to zha #69063

Closed
wants to merge 1 commit into from

Conversation

rforro
Copy link
Contributor

@rforro rforro commented Apr 1, 2022

Breaking change

Proposed change

THIS IS WIP, NEED YOUR ADVICE

My intention was to expose the AnalogInput zigbee cluster the same way like AnalogOutput is. That means in the first place I wanted to enable usage of following attributes:

  • 0x001C: ("description", t.CharacterString),
  • 0x0055: ("present_value", t.Single),
  • 0x0075: ("engineering_units", t.enum16),
  • 0x0100: ("application_type", t.uint32_t),

Here was I successfully. But in second place I wanted to make this AnalogInput entity to be more general (like AnalogOutput is). The plan was to replace those two detailed decorators:

@MULTI_MATCH(
channel_names=CHANNEL_ANALOG_INPUT,
manufacturers="LUMI",
models={"lumi.plug", "lumi.plug.maus01", "lumi.plug.mmeu01"},
stop_on_match_group=CHANNEL_ANALOG_INPUT,
)
@MULTI_MATCH(
channel_names=CHANNEL_ANALOG_INPUT,
manufacturers="Digi",
stop_on_match_group=CHANNEL_ANALOG_INPUT,
)
class AnalogInput(Sensor):

with just one simple @MULTI_MATCH(channel_names=CHANNEL_ANALOG_INPUT), but after few tries I'm 99% sure that this is impossible, because it will break too many quirks. I have to scope it to my device, but maybe there is something what I'm missing. Is there any chance to make it more general like the AnalogOutput?

@STRICT_MATCH(channel_names=CHANNEL_ANALOG_OUTPUT)
class ZhaNumber(ZhaEntity, NumberEntity):

The second problem what I have is, that because of those two @MULTI_MATCH this class AnalogInput(Sensor) cannot be tested. I've written the test case, but the mock device will never be matched with this entity. What can I do in this case?

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

The integration reached or maintains the following Integration Quality Scale:

  • No score or internal
  • 🥈 Silver
  • 🥇 Gold
  • 🏆 Platinum

To help with the load of incoming pull requests:

@probot-home-assistant
Copy link

Hey there @dmulcahey, @Adminiuga, mind taking a look at this pull request as it has been labeled with an integration (zha) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@MartinHjelmare MartinHjelmare changed the title added parametrizable analog input Add parametrizable analog input to zha Apr 1, 2022
@github-actions
Copy link

github-actions bot commented May 1, 2022

There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days.
Thank you for your contributions.

@github-actions github-actions bot added the stale label May 1, 2022
@github-actions github-actions bot closed this May 8, 2022
@github-actions github-actions bot locked and limited conversation to collaborators May 10, 2022
@rforro rforro deleted the zha-analoginput-extended branch May 16, 2022 20:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants