Add parametrizable analog input to zha #69063
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Breaking change
Proposed change
THIS IS WIP, NEED YOUR ADVICE
My intention was to expose the AnalogInput zigbee cluster the same way like AnalogOutput is. That means in the first place I wanted to enable usage of following attributes:
Here was I successfully. But in second place I wanted to make this AnalogInput entity to be more general (like AnalogOutput is). The plan was to replace those two detailed decorators:
core/homeassistant/components/zha/sensor.py
Lines 190 to 201 in a81194c
with just one simple
@MULTI_MATCH(channel_names=CHANNEL_ANALOG_INPUT)
, but after few tries I'm 99% sure that this is impossible, because it will break too many quirks. I have to scope it to my device, but maybe there is something what I'm missing. Is there any chance to make it more general like the AnalogOutput?core/homeassistant/components/zha/number.py
Lines 259 to 260 in a81194c
The second problem what I have is, that because of those two
@MULTI_MATCH
thisclass AnalogInput(Sensor)
cannot be tested. I've written the test case, but the mock device will never be matched with this entity. What can I do in this case?Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: