Correct return typing for catch_log_exception
#78399
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
probot-home-assistant
bot
added
code-quality
core
small-pr
balloob
reviewed
Sep 13, 2022
jbouwh
force-pushed
the
typing-log-helper
branch
from
87c6baa
to
adb5150
Compare
jbouwh
commented
Sep 14, 2022
I did some testing and it indeed takes away the mypy error. An alternative would be that if this PR gets merged first, then the typing in #77972 does not need to be changed: |
emontnemery
reviewed
Sep 15, 2022
jbouwh
force-pushed
the
typing-log-helper
branch
from
5dadc15
to
4912e0b
Compare
cdce8p
requested changes
Sep 17, 2022
There was a problem hiding this comment.
See #78399 (comment) for the reason behind the suggested changes
cdce8p
approved these changes
Sep 17, 2022
jbouwh
added a commit
to jbouwh/core
that referenced
this pull request
Sep 17, 2022
jbouwh
added a commit
that referenced
this pull request
Sep 17, 2022
* Use dataclass to reference hass.data globals * Add discovery_registry_hooks to dataclass * Move discovery registry hooks to dataclass * Add device triggers to dataclass * Cleanup DEVICE_TRIGGERS const * Add last_discovery to data_class * Simplify typing for class `Subscription` * Follow up on comment * Redo suggested typing change to sasisfy mypy * Restore typing * Add mypy version to CI check logging * revert changes to ci.yaml * Add docstr for protocol Co-authored-by: Marc Mueller <30130371+cdce8p@users.noreply.github.com> * Mypy update after merging #78399 * Remove mypy ignore * Correct return type Co-authored-by: Marc Mueller <30130371+cdce8p@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Correct return type for logging util
catch_log_exceptionSee #77972 (comment)
Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.The integration reached or maintains the following Integration Quality Scale:
To help with the load of incoming pull requests: