Support for Plex servers with enforced SSL #8341
Conversation
|
Hi @nmaggioni, It seems you haven't yet signed a CLA. Please do so here. Once you do that we will be able to review and accept this pull request. Thanks! |
| 'name': 'Use SSL', | ||
| 'type': '' | ||
| }, | ||
| { |
There was a problem hiding this comment.
continuation line missing indentation or outdented
| @@ -230,6 +253,16 @@ def plex_configuration_callback(data): | |||
| 'id': 'token', | |||
| 'name': 'X-Plex-Token', | |||
| 'type': '' | |||
| }, | |||
| { | |||
There was a problem hiding this comment.
continuation line missing indentation or outdented
| try: | ||
| plexserver = plexapi.server.PlexServer('http://%s' % host, token) | ||
| plexserver = plexapi.server.PlexServer('%s://%s' % (http_prefix, host), token, cert_session) |
There was a problem hiding this comment.
line too long (100 > 79 characters)
|
|
||
|
|
||
| def setup_plexserver(host, token, hass, config, add_devices_callback): | ||
| def setup_plexserver(host, token, has_ssl, verify_ssl, hass, config, add_devices_callback): |
| else: | ||
| return | ||
|
|
||
| setup_plexserver(host, token, hass, config, add_devices_callback) | ||
| setup_plexserver(host, token, has_ssl, verify_ssl, hass, config, add_devices_callback) |
| 'id': 'has_ssl', | ||
| 'name': 'Use SSL', | ||
| 'type': '' | ||
| },{ |
| @@ -230,6 +260,14 @@ def plex_configuration_callback(data): | |||
| 'id': 'token', | |||
| 'name': 'X-Plex-Token', | |||
| 'type': '' | |||
| },{ | |||
| @@ -217,7 +243,11 @@ def request_configuration(host, hass, config, add_devices_callback): | |||
| def plex_configuration_callback(data): | |||
| """Handle configuration changes.""" | |||
| setup_plexserver( | |||
| host, data.get('token'), hass, config, add_devices_callback) | |||
| host, data.get('token'), | |||
| True if data.get('has_ssl') else False, | |||
There was a problem hiding this comment.
You'll need to validate the data. Just presence of it is not enough. Use homeassistant.helpers.config_validation.boolean(value) to convert the values.
Better would be if you implement checkbox support in the frontend https://github.com/home-assistant/home-assistant-polymer/blob/master/src/more-infos/more-info-configurator.html#L66-L73
There was a problem hiding this comment.
I set up data validation; an update to the documentation PR is on its way.
Checkboxes would have been a much better alternative, but unfortunately I don't have enough experience in Polymer and the whole HA developing ecosystem to develop that feature at its best.
|
Have a look at the Travis build results. There are still some lint issues. The snips lint issue can be ignored (or fixed with a rebase) |
|
@balloob Anything else that needs improving? |
|
My bad. Was busy. 👍 all good |
|
No problem at all, life goes on for everyone :) What about the docs PR? |
* Update Plex docs for SSL connections (home-assistant/core#8341) * Stricter values allowed in the configurator home-assistant/core@f8808c6
* Support for Plex servers with enforced SSL * Fixed HoundCI warnings * Fixed HoundCI warnings (2nd) * Configurator data validation * Travis linting
ghost
removed
the
Description:
This PR introduces support for Plex servers that enforce SSL. Such servers may not have signed SSL certificates available for their local domain, causing connection failures for API requests.
The
plex.conffile format was updated to enable SSL connections and invalid certificate credentials, toggleable by the user. Safe defaults are in place: no SSL, and certificate validation enabled.@Hellowlol may want to take a look at this PR.
Related issue: fixes #7602
Pull request in home-assistant.github.io with documentation: home-assistant/home-assistant.io#2932
Example entry for
plex.conf:From this:
{"x.x.x.x:32400": {"token": "..."}}To this:
{"x.x.x.x:32400": {"token": "...", "ssl": true, "verify": false}}Checklist:
If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
toxrun successfully.New dependencies have been added to theREQUIREMENTSvariable ([example][ex-requir]).New dependencies are only imported inside functions that use them ([example][ex-import]).New dependencies have been added torequirements_all.txtby runningscript/gen_requirements_all.py.New files were added to.coveragerc.