Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate entity unique ids in PI-Hole #90883

Merged

Conversation

mib1185
Copy link
Contributor

@mib1185 mib1185 commented Apr 5, 2023

Proposed change

With #90713 building of entity unique id has been changed (from include description.name to description.key).
This is now fixed by migrating the unique ids

locally tested

2023-04-05 22:58:05.117 DEBUG (MainThread) [homeassistant.components.pi_hole] Setting up pi_hole integration with host x.x.x.x:80
2023-04-05 22:58:05.117 DEBUG (MainThread) [homeassistant.components.pi_hole] Migrate 6fa81c6b1ce11fbedb7b2f2391561fd5/Ads Percentage Blocked Today to 6fa81c6b1ce11fbedb7b2f2391561fd5/ads_percentage_today
2023-04-05 22:58:05.117 DEBUG (MainThread) [homeassistant.components.pi_hole] Migrate 6fa81c6b1ce11fbedb7b2f2391561fd5/Seen Clients to 6fa81c6b1ce11fbedb7b2f2391561fd5/clients_ever_seen
2023-04-05 22:58:05.118 DEBUG (MainThread) [homeassistant.components.pi_hole] Migrate 6fa81c6b1ce11fbedb7b2f2391561fd5/DNS Queries Today to 6fa81c6b1ce11fbedb7b2f2391561fd5/dns_queries_today
2023-04-05 22:58:05.118 DEBUG (MainThread) [homeassistant.components.pi_hole] Migrate 6fa81c6b1ce11fbedb7b2f2391561fd5/Domains Blocked to 6fa81c6b1ce11fbedb7b2f2391561fd5/domains_being_blocked
2023-04-05 22:58:05.118 DEBUG (MainThread) [homeassistant.components.pi_hole] Migrate 6fa81c6b1ce11fbedb7b2f2391561fd5/DNS Queries Cached to 6fa81c6b1ce11fbedb7b2f2391561fd5/queries_cached
2023-04-05 22:58:05.118 DEBUG (MainThread) [homeassistant.components.pi_hole] Migrate 6fa81c6b1ce11fbedb7b2f2391561fd5/DNS Queries Forwarded to 6fa81c6b1ce11fbedb7b2f2391561fd5/queries_forwarded
2023-04-05 22:58:05.118 DEBUG (MainThread) [homeassistant.components.pi_hole] Migrate 6fa81c6b1ce11fbedb7b2f2391561fd5/DNS Unique Clients to 6fa81c6b1ce11fbedb7b2f2391561fd5/unique_clients
2023-04-05 22:58:05.118 DEBUG (MainThread) [homeassistant.components.pi_hole] Migrate 6fa81c6b1ce11fbedb7b2f2391561fd5/DNS Unique Domains to 6fa81c6b1ce11fbedb7b2f2391561fd5/unique_domains
2023-04-05 22:58:05.118 DEBUG (MainThread) [homeassistant.components.pi_hole] Migrate 6fa81c6b1ce11fbedb7b2f2391561fd5/Ads Blocked Today to 6fa81c6b1ce11fbedb7b2f2391561fd5/ads_blocked_today
2023-04-05 22:58:05.119 DEBUG (MainThread) [homeassistant.components.pi_hole] Migrate 6fa81c6b1ce11fbedb7b2f2391561fd5/Core Update Available to 6fa81c6b1ce11fbedb7b2f2391561fd5/core_update_available
2023-04-05 22:58:05.119 DEBUG (MainThread) [homeassistant.components.pi_hole] Migrate 6fa81c6b1ce11fbedb7b2f2391561fd5/Web Update Available to 6fa81c6b1ce11fbedb7b2f2391561fd5/web_update_available
2023-04-05 22:58:05.119 DEBUG (MainThread) [homeassistant.components.pi_hole] Migrate 6fa81c6b1ce11fbedb7b2f2391561fd5/FTL Update Available to 6fa81c6b1ce11fbedb7b2f2391561fd5/ftl_update_available
2023-04-05 22:58:05.119 DEBUG (MainThread) [homeassistant.components.pi_hole] Migrate 6fa81c6b1ce11fbedb7b2f2391561fd5/Core Update Available to 6fa81c6b1ce11fbedb7b2f2391561fd5/core_update_available
2023-04-05 22:58:05.119 DEBUG (MainThread) [homeassistant.components.pi_hole] Migrate 6fa81c6b1ce11fbedb7b2f2391561fd5/Web Update Available to 6fa81c6b1ce11fbedb7b2f2391561fd5/web_update_available
2023-04-05 22:58:05.119 DEBUG (MainThread) [homeassistant.components.pi_hole] Migrate 6fa81c6b1ce11fbedb7b2f2391561fd5/FTL Update Available to 6fa81c6b1ce11fbedb7b2f2391561fd5/ftl_update_available
2023-04-05 22:58:05.119 DEBUG (MainThread) [homeassistant.components.pi_hole] Migrate 6fa81c6b1ce11fbedb7b2f2391561fd5/Status to 6fa81c6b1ce11fbedb7b2f2391561fd5/status

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link

home-assistant bot commented Apr 5, 2023

Hey there @johnluetke, @shenxn, mind taking a look at this pull request as it has been labeled with an integration (pi_hole) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of pi_hole can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign pi_hole Removes the current integration label and assignees on the pull request, add the integration domain after the command.

@balloob balloob merged commit 397fbc0 into home-assistant:dev Apr 6, 2023
@mib1185 mib1185 deleted the pi_hole/migrate-entity-unique-ids branch April 6, 2023 06:46
balloob added a commit that referenced this pull request Apr 6, 2023
* migrate entity unique ids

* Update homeassistant/components/pi_hole/__init__.py

---------

Co-authored-by: Paulus Schoutsen <paulus@home-assistant.io>
@balloob balloob mentioned this pull request Apr 6, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Apr 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants