Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix state being cleared on disconnect with deep sleep esphome devices #90925

Merged
merged 3 commits into from
Apr 6, 2023

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Apr 6, 2023

Proposed change

Fix state being cleared on disconnect with deep sleep esphome devices

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link

home-assistant bot commented Apr 6, 2023

Hey there @OttoWinter, @jesserockz, mind taking a look at this pull request as it has been labeled with an integration (esphome) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of esphome can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign esphome Removes the current integration label and assignees on the pull request, add the integration domain after the command.

@bdraco
Copy link
Member Author

bdraco commented Apr 6, 2023

Needs more testing but I'm too tired to build a deep sleep esphome device so will have to do it tomorrow

@balloob balloob modified the milestones: 2023.4.1, 2023.4.2 Apr 6, 2023
@bdraco bdraco marked this pull request as ready for review April 6, 2023 19:29
@bdraco
Copy link
Member Author

bdraco commented Apr 6, 2023

Tested with

---
esphome:
  name: deepsleep


deep_sleep:
  run_duration: 10s
  sleep_duration: 1min
  
esp32:
  board: nodemcu-32s

api:
  id: api_server


# WiFi connection, correct these
# with values for your WiFi.
wifi:
  ssid: SNIP
  password: SNIP

logger:
#  level: VERBOSE

# Enable Home Assistant API.

# Enable over-the-air updates.
ota:

# Enable Web server.
#web_server:
#  port: 80

# Sync time with Home Assistant.
time:
  - platform: homeassistant
    id: homeassistant_time

# Text sensors with general information.

# Sensors with general information.
sensor:
  # Uptime sensor.
  - platform: uptime
    name: deepsleep Uptime
  - platform: template
    name: deepsleep free Memory
    lambda: return heap_caps_get_free_size(MALLOC_CAP_INTERNAL);
    unit_of_measurement: 'B'
    state_class: measurement
  - platform: wifi_signal
    name: "WiFi Signal Sensor"
    update_interval: 2s

@bdraco bdraco mentioned this pull request Apr 6, 2023
@balloob balloob modified the milestones: 2023.4.2, 2023.4.1 Apr 6, 2023
@balloob balloob merged commit 87c22c3 into dev Apr 6, 2023
@balloob balloob deleted the esphome_sleepy_devices branch April 6, 2023 20:32
balloob pushed a commit that referenced this pull request Apr 6, 2023
…#90925)

* Fix state being cleared on disconnect with deep sleep esphome devices

fixes #90923

* fix logic
@Kimotu
Copy link

Kimotu commented Apr 7, 2023

Thanks for the fast fix. Just installed 2023.4.1 and dashboard shows last value again till next sensor update. 🙂

@github-actions github-actions bot locked and limited conversation to collaborators Apr 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ESPhome deep sleep sensor values get 'unavailable' as soon as api is not connected
5 participants