Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump roborock to 0.8.1 for beta fixes #92131

Merged
merged 3 commits into from
Apr 27, 2023

Conversation

Lash-L
Copy link
Contributor

@Lash-L Lash-L commented Apr 27, 2023

Breaking change

Proposed change

Bumps the version from 0.6.5 to 0.8.1

Changelog: https://github.com/humbertogontijo/python-roborock/blob/main/CHANGELOG.md

Summary:

  • fixes missing dock info (not used in core, but when the dataclasses get built if the data is missing it throws an error)
  • Improves how the local api works
  • adds better error catching for setting up a account
  • The rest of the changes are not used in core

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @humbertogontijo, mind taking a look at this pull request as it has been labeled with an integration (roborock) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of roborock can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign roborock Removes the current integration label and assignees on the pull request, add the integration domain after the command.

@MartinHjelmare MartinHjelmare changed the title bump roborock to 0.8.1 for beta fixes Bump roborock to 0.8.1 for beta fixes Apr 27, 2023
@home-assistant home-assistant bot marked this pull request as draft April 27, 2023 18:02
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@Lash-L Lash-L marked this pull request as ready for review April 27, 2023 18:27
Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MartinHjelmare MartinHjelmare added this to the 2023.5.0 milestone Apr 27, 2023
@MartinHjelmare MartinHjelmare merged commit efec50c into home-assistant:dev Apr 27, 2023
frenck pushed a commit that referenced this pull request Apr 28, 2023
* bump to 0.8.1

* add tests for new config flow errors

* removed logs for known errors
@github-actions github-actions bot locked and limited conversation to collaborators Apr 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Roborock unexpected error initializing Roborock not intializing. Can not add Roborock Integration
3 participants