Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove outdated HAOS check from bluetooth #93809

Merged
merged 1 commit into from
May 30, 2023
Merged

Remove outdated HAOS check from bluetooth #93809

merged 1 commit into from
May 30, 2023

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented May 30, 2023

Proposed change

When bluetooth was released we had a lot of problems with outdated HAOS. This check was added to reduce the influx of issues and get users in a good place. Analytics shows that almost every reporting install is at 9.x+ or later

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

When bluetooth was released we had a lot of problems with
outdated HAOS. This check was added to reduce the influx
of issues and get users in a good place. Analytics shows
that almost every reporting install is at 9.x+ or later
@frenck frenck merged commit 17d1c07 into dev May 30, 2023
@frenck frenck deleted the bluetooth_haos_check branch May 30, 2023 17:41
@bdraco
Copy link
Member Author

bdraco commented May 31, 2023

thanks

@github-actions github-actions bot locked and limited conversation to collaborators Jun 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants