-
-
Notifications
You must be signed in to change notification settings - Fork 30.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove repair issue for MQTT discovered items #98768
Conversation
Hey there @emontnemery, @jbouwh, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
4003543
to
cb7f51c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see you corrected things
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM,
Thnx @frenck 👍
Proposed change
This PR reverts/removes the creation of repairs issues for the MQTT integration, on entities that are created by MQTT discovery, as introduced in Home Assistant 2023.8.
These repair issues seem to cause/trigger quite a lot of fuzz that should not be needed; there are quite a lot of topics across different socials on this.
This repair issue is mostly misunderstood as a breaking change, while it is not breaking at all. The original intent was to inform and to get people to report issues upstream to third-party software that integrate with Home Assistant over MQTT. It is currently handled gracefully and in a backward-compatible manner for the end-user.
Repair issues must be fixable by the user; however, in this case, it currently isn't actionable by most users as most discovery payloads aren't created by users but by the third-party software.
One of the bigger pieces of software triggering this issue, is Zigbee2MQTT. An adjustment for this missed their release cut, meaning these users get these repairs too (which is a big part of our community).
The goal of getting MQTT naming up to par with the rest of the Home Assistant integrations remains; This in order to support a better and more standardized naming of entities and devices across Home Assistant (so we can provide better naming depending on the user context in the future).
ℹ️ Marking this PR for the 2023.8.4 patch release that is planned for the 24th of August.
Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: