Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove repair issue for MQTT discovered items #98768

Merged
merged 1 commit into from Aug 21, 2023
Merged

Remove repair issue for MQTT discovered items #98768

merged 1 commit into from Aug 21, 2023

Conversation

frenck
Copy link
Member

@frenck frenck commented Aug 21, 2023

Proposed change

This PR reverts/removes the creation of repairs issues for the MQTT integration, on entities that are created by MQTT discovery, as introduced in Home Assistant 2023.8.

  • These repair issues seem to cause/trigger quite a lot of fuzz that should not be needed; there are quite a lot of topics across different socials on this.

  • This repair issue is mostly misunderstood as a breaking change, while it is not breaking at all. The original intent was to inform and to get people to report issues upstream to third-party software that integrate with Home Assistant over MQTT. It is currently handled gracefully and in a backward-compatible manner for the end-user.

  • Repair issues must be fixable by the user; however, in this case, it currently isn't actionable by most users as most discovery payloads aren't created by users but by the third-party software.

  • One of the bigger pieces of software triggering this issue, is Zigbee2MQTT. An adjustment for this missed their release cut, meaning these users get these repairs too (which is a big part of our community).

  • The goal of getting MQTT naming up to par with the rest of the Home Assistant integrations remains; This in order to support a better and more standardized naming of entities and devices across Home Assistant (so we can provide better naming depending on the user context in the future).

ℹ️ Marking this PR for the 2023.8.4 patch release that is planned for the 24th of August.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @emontnemery, @jbouwh, mind taking a look at this pull request as it has been labeled with an integration (mqtt) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of mqtt can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign mqtt Removes the current integration label and assignees on the pull request, add the integration domain after the command.

@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant home-assistant bot marked this pull request as draft August 21, 2023 17:28
Copy link
Contributor

@jbouwh jbouwh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see you corrected things

homeassistant/components/mqtt/mixins.py Show resolved Hide resolved
Copy link
Contributor

@jbouwh jbouwh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM,
Thnx @frenck 👍

@frenck frenck marked this pull request as ready for review August 21, 2023 18:03
@home-assistant home-assistant bot requested a review from jbouwh August 21, 2023 18:03
@frenck frenck merged commit c39fc07 into dev Aug 21, 2023
30 checks passed
@frenck frenck deleted the frenck-2023-1166 branch August 21, 2023 18:03
@github-actions github-actions bot locked and limited conversation to collaborators Aug 22, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants