-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Lovelace: Allow glance card to assume theme colors #1732
Conversation
I am not a fan of boolean config options as they don't usually hold well. Can we do something like: |
I think that we should not allow theming to be a dict. Let's start very small, see what use cases are coming up . |
Can you add the theming = primary to one of the demo glances? https://github.com/home-assistant/home-assistant-polymer/blob/master/gallery/src/demos/demo-hui-glance-card.js |
🐬 🎉 |
@balloob I need to know what 🐬 🎉 means 😄 |
* Allow glance card to assume theme colors * Better configuration options * Added example to gallery * Fixing problems from review
* Allow glance card to assume theme colors * Better configuration options * Added example to gallery * Fixing problems from review
* Allow glance card to assume theme colors * Better configuration options * Added example to gallery * Fixing problems from review
* Allow glance card to assume theme colors * Better configuration options * Added example to gallery * Fixing problems from review
Edit: Documentation added: home-assistant/home-assistant.io#6506
This change lets the glance card act like color-glance-card.
For now a sample config looks like this:
I'm not sure about the name of the config variable, though, and as @balloob pointed out in discord, making it a boolean means values can't be added later.
Posting this as a WIP, hoping for ideas and advice.