Lovelace: Allow glance card to assume theme colors #1732
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
|
I am not a fan of boolean config options as they don't usually hold well. Can we do something like: |
|
All colors are from the current theme, btw. |
|
Fewer choices, yet more... May be a bit confusing that |
|
I think that we should not allow theming to be a dict. Let's start very small, see what use cases are coming up . |
|
- type: glance
title: default
theming: default
entities: ...
- type: glance
title: primary
theming: primary
entities: ...
- type: glance
title: none
entities: ... |
thomasloven
changed the title
Merged
2 tasks
balloob
reviewed
Oct 4, 2018
balloob
reviewed
Oct 4, 2018
balloob
reviewed
Oct 4, 2018
|
Can you add the theming = primary to one of the demo glances? https://github.com/home-assistant/home-assistant-polymer/blob/master/gallery/src/demos/demo-hui-glance-card.js |
balloob
approved these changes
Oct 4, 2018
|
🐬 🎉 |
|
@balloob I need to know what 🐬 🎉 means 😄 |
|
|
|
|
balloob
pushed a commit
to home-assistant/home-assistant.io
that referenced
this pull request
Oct 5, 2018
zsarnett
pushed a commit
to zsarnett/home-assistant-polymer
that referenced
this pull request
Oct 13, 2018
* Allow glance card to assume theme colors * Better configuration options * Added example to gallery * Fixing problems from review
zsarnett
pushed a commit
to zsarnett/home-assistant-polymer
that referenced
this pull request
Oct 13, 2018
* Allow glance card to assume theme colors * Better configuration options * Added example to gallery * Fixing problems from review
zsarnett
pushed a commit
to zsarnett/home-assistant-polymer
that referenced
this pull request
Oct 14, 2018
* Allow glance card to assume theme colors * Better configuration options * Added example to gallery * Fixing problems from review
zsarnett
pushed a commit
to zsarnett/home-assistant-polymer
that referenced
this pull request
Oct 14, 2018
* Allow glance card to assume theme colors * Better configuration options * Added example to gallery * Fixing problems from review
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Edit: Documentation added: home-assistant/home-assistant.io#6506
This change lets the glance card act like color-glance-card.
For now a sample config looks like this:
I'm not sure about the name of the config variable, though, and as @balloob pointed out in discord, making it a boolean means values can't be added later.
Posting this as a WIP, hoping for ideas and advice.