Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add todo component that supports multiple To-do lists. #17883

Closed
wants to merge 8 commits into from

Conversation

allenporter
Copy link
Contributor

@allenporter allenporter commented Sep 10, 2023

Proposed change

This updates the existing shopping-list card with support for managing multiple To-do lists using the todo component. The component is compatible with shopping-list and can support other integrations providing a To-do List.

The shopping_list panel is renamed to todo. However, to avoid confusion for existing shopping cart users, the icon still looks like a shopping card, but it has a check next to it like a to-do check.

The shopping_list card now can show a drop down list of a To-do list to select, or it can be configured with a specific To-do list to just show that list.

An alternative could be to leave shopping list alone and create another To-do List card, rather than going with this hybrid approach that could be a little confusing. Open to discussing the right approach for backwards compatibility as well as maintenance.

Work items:

  • Fix translations
  • Implement switching between entities
  • Move edit commands to To-do list websocket APIs
  • verify on a second todo implementation (e.g. local todo, todoist)

Initial demo extending Shopping list card to support To-do lists:
Todo lists

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@allenporter allenporter marked this pull request as draft October 8, 2023 15:26
@allenporter
Copy link
Contributor Author

I am closing since @bramkragten is going to take this with a bigger scope.

@github-actions github-actions bot locked and limited conversation to collaborators Oct 9, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant