Add option to show current temperature on thermostat card #19049
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
piitaya
changed the title
|
Should the thermostat icon also be shown on a dual setpoint (if there is space)? |
piitaya
force-pushed
the
show_current_temperature_thermostat
branch
from
f9328c8
to
027bea4
Compare
bramkragten
reviewed
Dec 18, 2023
src/panels/lovelace/cards/types.ts
Outdated
| @@ -455,6 +455,7 @@ export interface ThermostatCardConfig extends LovelaceCardConfig { | |||
| entity: string; | |||
| theme?: string; | |||
| name?: string; | |||
| use_current_as_primary?: boolean; | |||
There was a problem hiding this comment.
I think I prefer
Suggested change
| use_current_as_primary?: boolean; | |
| show_current_as_primary?: boolean; |
There was a problem hiding this comment.
I wasn't sure for the name. I agree with your suggestion.
bramkragten
reviewed
Dec 18, 2023
| return html` | ||
| <p class="label"> | ||
| ${action && action !== "off" && action !== "idle" | ||
| ? actionLabel | ||
| : this.hass.localize("ui.card.climate.target")} |
There was a problem hiding this comment.
Lokalize key is no longer used? Can be removed?
bramkragten
approved these changes
Dec 20, 2023
Merged
8 tasks
|
Now all that is left is to make the old behavior default and then we could forget all this nonsense as if it has never happened |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Add option to thermostat card to use current temperature instead of target temperature as main info.
PR for humidifier will follow.
Type of change
Example configuration
Additional information
Checklist
If user exposed functionality or configuration variables are added/changed: