Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ha-form-file element for file upload support in ha-form #20657

Conversation

raulcodes
Copy link

Breaking change

Proposed change

Add support for file uploads in config flows.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New feature (thank you!)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Example configuration

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue or discussion: Corresponding core PR
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • There is no commented out code in this PR.
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

@bramkragten
Copy link
Member

bramkragten commented Apr 29, 2024

Why did you choose to add this to ha-form instead of using the file selector?

@customElement("ha-selector-file")

@raulcodes
Copy link
Author

@bramkragten Because I didn't know that existed. Thanks for the feedback and callout! closing this as a no-op.

@raulcodes raulcodes closed this Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants